Skip to content

Commit 9737909

Browse files
jhovoldgregkh
authored andcommitted
mceusb: fix NULL-deref at probe
commit 03eb2a557ed552e920a0942b774aaf931596eec1 upstream. Make sure to check for the required out endpoint to avoid dereferencing a NULL-pointer in mce_request_packet should a malicious device lack such an endpoint. Note that this path is hit during probe. Fixes: 66e8952 ("V4L/DVB: IR: add mceusb IR receiver driver") Signed-off-by: Johan Hovold <johan@kernel.org> Signed-off-by: Sean Young <sean@mess.org> Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent f05c0df commit 9737909

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

drivers/media/rc/mceusb.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1321,8 +1321,8 @@ static int mceusb_dev_probe(struct usb_interface *intf,
13211321
}
13221322
}
13231323
}
1324-
if (ep_in == NULL) {
1325-
dev_dbg(&intf->dev, "inbound and/or endpoint not found");
1324+
if (!ep_in || !ep_out) {
1325+
dev_dbg(&intf->dev, "required endpoints not found\n");
13261326
return -ENODEV;
13271327
}
13281328

0 commit comments

Comments
 (0)