PKCS#7: fix unitialized boolean 'want'

Colin Ian King · gregkh · commit 9c405157269d · 2017-11-15T17:13:14.000+01:00
commit 06aae592425701851e02bb850cb9f4997f0ae163 upstream.

The boolean want is not initialized and hence garbage. The default should
be false (later it is only set to true on tne sinfo-&gt;authattrs check).

Found with static analysis using CoverityScan

Signed-off-by: Colin Ian King &lt;colin.king@canonical.com&gt;
Signed-off-by: David Howells &lt;dhowells@redhat.com&gt;
Cc: Ben Hutchings &lt;ben.hutchings@codethink.co.uk&gt;
Signed-off-by: Greg Kroah-Hartman &lt;gregkh@linuxfoundation.org&gt;
diff --git a/crypto/asymmetric_keys/pkcs7_parser.c b/crypto/asymmetric_keys/pkcs7_parser.c
@@ -87,7 +87,7 @@ EXPORT_SYMBOL_GPL(pkcs7_free_message);
 static int pkcs7_check_authattrs(struct pkcs7_message *msg)
 {
 	struct pkcs7_signed_info *sinfo;
-	bool want;
+	bool want = false;
 
 	sinfo = msg->signed_infos;
 	if (!sinfo)

Original file line number	Diff line number	Diff line change
`@@ -87,7 +87,7 @@ EXPORT_SYMBOL_GPL(pkcs7_free_message);`
`87`	`87`	`static int pkcs7_check_authattrs(struct pkcs7_message *msg)`
`88`	`88`	`{`
`89`	`89`	`struct pkcs7_signed_info *sinfo;`
`90`		`- bool want;`
	`90`	`+ bool want = false;`
`91`	`91`
`92`	`92`	`sinfo = msg->signed_infos;`
`93`	`93`	`if (!sinfo)`