Skip to content

Commit a32c533

Browse files
MaxBiresgregkh
authored andcommitted
char: lack of bool string made CONFIG_DEVPORT always on
commit f2cfa58b136e4b06a9b9db7af5ef62fbb5992f62 upstream. Without a bool string present, using "# CONFIG_DEVPORT is not set" in defconfig files would not actually unset devport. This esnured that /dev/port was always on, but there are reasons a user may wish to disable it (smaller kernel, attack surface reduction) if it's not being used. Adding a message here in order to make this user visible. Signed-off-by: Max Bires <jbires@google.com> Acked-by: Arnd Bergmann <arnd@arndb.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent 0a6aa0d commit a32c533

1 file changed

Lines changed: 4 additions & 1 deletion

File tree

drivers/char/Kconfig

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -583,9 +583,12 @@ config TELCLOCK
583583
controlling the behavior of this hardware.
584584

585585
config DEVPORT
586-
bool
586+
bool "/dev/port character device"
587587
depends on ISA || PCI
588588
default y
589+
help
590+
Say Y here if you want to support the /dev/port device. The /dev/port
591+
device is similar to /dev/mem, but for I/O ports.
589592

590593
source "drivers/s390/char/Kconfig"
591594

0 commit comments

Comments
 (0)