Skip to content

Commit aad7041

Browse files
SinkFindergregkh
authored andcommitted
iommu/amd: Fix incorrect error handling in amd_iommu_bind_pasid()
commit 73dbd4a4230216b6a5540a362edceae0c9b4876b upstream. In function amd_iommu_bind_pasid(), the control flow jumps to label out_free when pasid_state->mm and mm is NULL. And mmput(mm) is called. In function mmput(mm), mm is referenced without validation. This will result in a NULL dereference bug. This patch fixes the bug. Signed-off-by: Pan Bian <bianpan2016@163.com> Fixes: f0aac63 ('iommu/amd: Don't hold a reference to mm_struct') Signed-off-by: Joerg Roedel <jroedel@suse.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent 48952c6 commit aad7041

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

drivers/iommu/amd_iommu_v2.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -699,9 +699,9 @@ int amd_iommu_bind_pasid(struct pci_dev *pdev, int pasid,
699699

700700
out_unregister:
701701
mmu_notifier_unregister(&pasid_state->mn, mm);
702+
mmput(mm);
702703

703704
out_free:
704-
mmput(mm);
705705
free_pasid_state(pasid_state);
706706

707707
out:

0 commit comments

Comments
 (0)