Skip to content

Commit b0bc7fc

Browse files
Yunlei Hepundiramit
authored andcommitted
f2fs: fix a missing discard prefree segments
commit 650d3c4e56e1e92ee6e004648c9deb243e5963e0 upstream. If userspace issue a fstrim with a range not involve prefree segments, it will reuse these segments without discard. This patch fix it. Signed-off-by: Yunlei He <heyunlei@huawei.com> Reviewed-by: Chao Yu <yuchao0@huawei.com> Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
1 parent 7c033b7 commit b0bc7fc

1 file changed

Lines changed: 9 additions & 1 deletion

File tree

fs/f2fs/segment.c

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -996,9 +996,13 @@ void clear_prefree_segments(struct f2fs_sb_info *sbi, struct cp_control *cpc)
996996

997997
dirty_i->nr_dirty[PRE] -= end - start;
998998

999-
if (force || !test_opt(sbi, DISCARD))
999+
if (!test_opt(sbi, DISCARD))
10001000
continue;
10011001

1002+
if (force && start >= cpc->trim_start &&
1003+
(end - 1) <= cpc->trim_end)
1004+
continue;
1005+
10021006
if (!test_opt(sbi, LFS) || sbi->segs_per_sec == 1) {
10031007
f2fs_issue_discard(sbi, START_BLOCK(sbi, start),
10041008
(end - start) << sbi->log_blocks_per_seg);
@@ -2343,8 +2347,12 @@ void flush_sit_entries(struct f2fs_sb_info *sbi, struct cp_control *cpc)
23432347
f2fs_bug_on(sbi, sit_i->dirty_sentries);
23442348
out:
23452349
if (cpc->reason == CP_DISCARD) {
2350+
__u64 trim_start = cpc->trim_start;
2351+
23462352
for (; cpc->trim_start <= cpc->trim_end; cpc->trim_start++)
23472353
add_discard_addrs(sbi, cpc);
2354+
2355+
cpc->trim_start = trim_start;
23482356
}
23492357
mutex_unlock(&sit_i->sentry_lock);
23502358

0 commit comments

Comments
 (0)