Skip to content

Commit b27e9ff

Browse files
Boris Brezillongregkh
authored andcommitted
irqchip/atmel-aic: Fix unbalanced refcount in aic_common_rtc_irq_fixup()
commit 277867ade8262583f4280cadbe90e0031a3706a7 upstream. of_find_compatible_node() is calling of_node_put() on its first argument thus leading to an unbalanced of_node_get/put() issue if the node has not been retained before that. Instead of passing the root node, pass NULL, which does exactly the same: iterate over all DT nodes, starting from the root node. Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com> Reported-by: Alexandre Belloni <alexandre.belloni@free-electrons.com> Fixes: 3d61467 ("irqchip: atmel-aic: Implement RTC irq fixup") Signed-off-by: Marc Zyngier <marc.zyngier@arm.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent ed281a6 commit b27e9ff

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

drivers/irqchip/irq-atmel-aic-common.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -148,9 +148,9 @@ void __init aic_common_rtc_irq_fixup(struct device_node *root)
148148
struct device_node *np;
149149
void __iomem *regs;
150150

151-
np = of_find_compatible_node(root, NULL, "atmel,at91rm9200-rtc");
151+
np = of_find_compatible_node(NULL, NULL, "atmel,at91rm9200-rtc");
152152
if (!np)
153-
np = of_find_compatible_node(root, NULL,
153+
np = of_find_compatible_node(NULL, NULL,
154154
"atmel,at91sam9x5-rtc");
155155

156156
if (!np)

0 commit comments

Comments
 (0)