Skip to content

Commit b4ca98b

Browse files
bjking1gregkh
authored andcommitted
i40evf: Use smp_rmb rather than read_barrier_depends
commit f72271e2a0ae4277d53c4053f5eed8bb346ba38a upstream. The original issue being fixed in this patch was seen with the ixgbe driver, but the same issue exists with i40evf as well, as the code is very similar. read_barrier_depends is not sufficient to ensure loads following it are not speculatively loaded out of order by the CPU, which can result in stale data being loaded, causing potential system crashes. Signed-off-by: Brian King <brking@linux.vnet.ibm.com> Acked-by: Jesse Brandeburg <jesse.brandeburg@intel.com> Tested-by: Andrew Bowers <andrewx.bowers@intel.com> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent a8e699d commit b4ca98b

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

drivers/net/ethernet/intel/i40evf/i40e_txrx.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -172,7 +172,7 @@ static bool i40e_clean_tx_irq(struct i40e_ring *tx_ring, int budget)
172172
break;
173173

174174
/* prevent any other reads prior to eop_desc */
175-
read_barrier_depends();
175+
smp_rmb();
176176

177177
/* we have caught up to head, no work left to do */
178178
if (tx_head == tx_desc)

0 commit comments

Comments
 (0)