Skip to content

Commit b66baf4

Browse files
jwrdegoedegregkh
authored andcommitted
USB: uas: Fix slave queue_depth not being set
commit 593224ea77b1ca842f45cf76f4deeef44dfbacd1 upstream. Commit 198de51dbc34 ("USB: uas: Limit qdepth at the scsi-host level") removed the scsi_change_queue_depth() call from uas_slave_configure() assuming that the slave would inherit the host's queue_depth, which that commit sets to the same value. This is incorrect, without the scsi_change_queue_depth() call the slave's queue_depth defaults to 1, introducing a performance regression. This commit restores the call, fixing the performance regression. Fixes: 198de51dbc34 ("USB: uas: Limit qdepth at the scsi-host level") Reported-by: Tom Yan <tom.ty89@gmail.com> Signed-off-by: Hans de Goede <hdegoede@redhat.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent ce1abd2 commit b66baf4

1 file changed

Lines changed: 1 addition & 0 deletions

File tree

drivers/usb/storage/uas.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -811,6 +811,7 @@ static int uas_slave_configure(struct scsi_device *sdev)
811811
if (devinfo->flags & US_FL_BROKEN_FUA)
812812
sdev->broken_fua = 1;
813813

814+
scsi_change_queue_depth(sdev, devinfo->qdepth - 2);
814815
return 0;
815816
}
816817

0 commit comments

Comments
 (0)