Skip to content

Commit b829834

Browse files
Dan Carpenterdvhart
authored andcommitted
asus-wmi: fix error handling in store_sys_wmi()
The asus_wmi_get_devstate_simple() returns 0-1 on success. In theory according to static checkers, it can return either -EIO or -ENODEV on failure. Currently the error handling code only handles -ENODEV and -EIO is treated as success. Let's make it handle the -EIO error as well. It's possible that it can't actually return -EIO and this patch is not needed but in that case this patch is harmless and silences a static checker warning so it's still worth it. Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Darren Hart <dvhart@linux.intel.com>
1 parent f71c882 commit b829834

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

drivers/platform/x86/asus-wmi.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1682,7 +1682,7 @@ static ssize_t store_sys_wmi(struct asus_wmi *asus, int devid,
16821682
int rv, err, value;
16831683

16841684
value = asus_wmi_get_devstate_simple(asus, devid);
1685-
if (value == -ENODEV) /* Check device presence */
1685+
if (value < 0)
16861686
return value;
16871687

16881688
rv = parse_arg(buf, count, &value);

0 commit comments

Comments
 (0)