Skip to content

Commit bd36826

Browse files
djwonggregkh
authored andcommitted
ext4: in ext4_seek_{hole,data}, return -ENXIO for negative offsets
commit 1bd8d6cd3e413d64e543ec3e69ff43e75a1cf1ea upstream. In the ext4 implementations of SEEK_HOLE and SEEK_DATA, make sure we return -ENXIO for negative offsets instead of banging around inside the extent code and returning -EFSCORRUPTED. Reported-by: Mateusz S <muttdini@gmail.com> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com> Signed-off-by: Theodore Ts'o <tytso@mit.edu> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent 6721969 commit bd36826

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

fs/ext4/file.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -559,7 +559,7 @@ static loff_t ext4_seek_data(struct file *file, loff_t offset, loff_t maxsize)
559559
mutex_lock(&inode->i_mutex);
560560

561561
isize = i_size_read(inode);
562-
if (offset >= isize) {
562+
if (offset < 0 || offset >= isize) {
563563
mutex_unlock(&inode->i_mutex);
564564
return -ENXIO;
565565
}
@@ -632,7 +632,7 @@ static loff_t ext4_seek_hole(struct file *file, loff_t offset, loff_t maxsize)
632632
mutex_lock(&inode->i_mutex);
633633

634634
isize = i_size_read(inode);
635-
if (offset >= isize) {
635+
if (offset < 0 || offset >= isize) {
636636
mutex_unlock(&inode->i_mutex);
637637
return -ENXIO;
638638
}

0 commit comments

Comments
 (0)