Skip to content

Commit c21636b

Browse files
Li Qianggregkh
authored andcommitted
drm/vmwgfx: fix integer overflow in vmw_surface_define_ioctl()
commit e7e11f99564222d82f0ce84bd521e57d78a6b678 upstream. In vmw_surface_define_ioctl(), the 'num_sizes' is the sum of the 'req->mip_levels' array. This array can be assigned any value from the user space. As both the 'num_sizes' and the array is uint32_t, it is easy to make 'num_sizes' overflow. The later 'mip_levels' is used as the loop count. This can lead an oob write. Add the check of 'req->mip_levels' to avoid this. Signed-off-by: Li Qiang <liqiang6-s@360.cn> Reviewed-by: Thomas Hellstrom <thellstrom@vmware.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent 235e914 commit c21636b

1 file changed

Lines changed: 4 additions & 1 deletion

File tree

drivers/gpu/drm/vmwgfx/vmwgfx_surface.c

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -715,8 +715,11 @@ int vmw_surface_define_ioctl(struct drm_device *dev, void *data,
715715
128;
716716

717717
num_sizes = 0;
718-
for (i = 0; i < DRM_VMW_MAX_SURFACE_FACES; ++i)
718+
for (i = 0; i < DRM_VMW_MAX_SURFACE_FACES; ++i) {
719+
if (req->mip_levels[i] > DRM_VMW_MAX_MIP_LEVELS)
720+
return -EINVAL;
719721
num_sizes += req->mip_levels[i];
722+
}
720723

721724
if (num_sizes > DRM_VMW_MAX_SURFACE_FACES * DRM_VMW_MAX_MIP_LEVELS ||
722725
num_sizes == 0)

0 commit comments

Comments
 (0)