Skip to content

Commit c51451e

Browse files
EmbeddedAndroidgregkh
authored andcommitted
irqchip/irq-imx-gpcv2: Fix spinlock initialization
commit 75eb5e1e7b4edbc8e8f930de59004d21cb46961f upstream. The raw_spinlock in the IMX GPCV2 interupt chip is not initialized before usage. That results in a lockdep splat: INFO: trying to register non-static key. the code is fine but needs lockdep annotation. turning off the locking correctness validator. Add the missing raw_spin_lock_init() to the setup code. Fixes: e324c4d ("irqchip/imx-gpcv2: IMX GPCv2 driver for wakeup sources") Signed-off-by: Tyler Baker <tyler.baker@linaro.org> Reviewed-by: Fabio Estevam <fabio.estevam@nxp.com> Cc: jason@lakedaemon.net Cc: marc.zyngier@arm.com Cc: shawnguo@kernel.org Cc: andrew.smirnov@gmail.com Cc: linux-arm-kernel@lists.infradead.org Link: http://lkml.kernel.org/r/20170413222731.5917-1-tyler.baker@linaro.org Signed-off-by: Thomas Gleixner <tglx@linutronix.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent 66b531d commit c51451e

1 file changed

Lines changed: 2 additions & 0 deletions

File tree

drivers/irqchip/irq-imx-gpcv2.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -230,6 +230,8 @@ static int __init imx_gpcv2_irqchip_init(struct device_node *node,
230230
return -ENOMEM;
231231
}
232232

233+
raw_spin_lock_init(&cd->rlock);
234+
233235
cd->gpc_base = of_iomap(node, 0);
234236
if (!cd->gpc_base) {
235237
pr_err("fsl-gpcv2: unable to map gpc registers\n");

0 commit comments

Comments
 (0)