Skip to content

Commit c6c6851

Browse files
Allen Hubbegregkh
authored andcommitted
NTB: ntb_transport: fix debugfs_remove_recursive
commit dd62245e73de9138333cb0e7a42c8bc1215c3ce6 upstream. The call to debugfs_remove_recursive(qp->debugfs_dir) of the sub-level directory must not be later than debugfs_remove_recursive(nt_debugfs_dir) of the top-level directory. Otherwise, the sub-level directory will not exist, and it would be invalid (panic) to attempt to remove it. This removes the top-level directory last, after sub-level directories have been cleaned up. Signed-off-by: Allen Hubbe <Allen.Hubbe@dell.com> Fixes: e26a584 ("NTB: Split ntb_hw_intel and ntb_transport drivers") Signed-off-by: Jon Mason <jdmason@kudzu.us> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent efa0619 commit c6c6851

1 file changed

Lines changed: 1 addition & 2 deletions

File tree

drivers/ntb/ntb_transport.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2082,9 +2082,8 @@ module_init(ntb_transport_init);
20822082

20832083
static void __exit ntb_transport_exit(void)
20842084
{
2085-
debugfs_remove_recursive(nt_debugfs_dir);
2086-
20872085
ntb_unregister_client(&ntb_transport_client);
20882086
bus_unregister(&ntb_transport_bus);
2087+
debugfs_remove_recursive(nt_debugfs_dir);
20892088
}
20902089
module_exit(ntb_transport_exit);

0 commit comments

Comments
 (0)