Skip to content

Commit ce3dcfd

Browse files
jason77-wanggregkh
authored andcommitted
ALSA: hda - fix a problem for lineout on a Dell AIO machine
commit 2f726aec19a9d2c63bec9a8a53a3910ffdcd09f8 upstream. On this Dell AIO machine, the lineout jack does not work. We found the pin 0x1a is assigned to lineout on this machine, and in the past, we applied ALC298_FIXUP_DELL1_MIC_NO_PRESENCE to fix the heaset-set mic problem for this machine, this fixup will redefine the pin 0x1a to headphone-mic, as a result the lineout doesn't work anymore. After consulting with Dell, they told us this machine doesn't support microphone via headset jack, so we add a new fixup which only defines the pin 0x18 as the headset-mic. [rearranged the fixup insertion position by tiwai in order to make the merge with other branches easier -- tiwai] Fixes: 59ec4b57bcae ("ALSA: hda - Fix headset mic detection problem for two dell machines") Signed-off-by: Hui Wang <hui.wang@canonical.com> Signed-off-by: Takashi Iwai <tiwai@suse.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent a90d744 commit ce3dcfd

1 file changed

Lines changed: 11 additions & 1 deletion

File tree

sound/pci/hda/patch_realtek.c

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4831,6 +4831,7 @@ enum {
48314831
ALC292_FIXUP_DISABLE_AAMIX,
48324832
ALC293_FIXUP_DISABLE_AAMIX_MULTIJACK,
48334833
ALC298_FIXUP_DELL1_MIC_NO_PRESENCE,
4834+
ALC298_FIXUP_DELL_AIO_MIC_NO_PRESENCE,
48344835
ALC275_FIXUP_DELL_XPS,
48354836
ALC256_FIXUP_DELL_XPS_13_HEADPHONE_NOISE,
48364837
ALC293_FIXUP_LENOVO_SPK_NOISE,
@@ -5429,6 +5430,15 @@ static const struct hda_fixup alc269_fixups[] = {
54295430
.chained = true,
54305431
.chain_id = ALC269_FIXUP_HEADSET_MODE
54315432
},
5433+
[ALC298_FIXUP_DELL_AIO_MIC_NO_PRESENCE] = {
5434+
.type = HDA_FIXUP_PINS,
5435+
.v.pins = (const struct hda_pintbl[]) {
5436+
{ 0x18, 0x01a1913c }, /* use as headset mic, without its own jack detect */
5437+
{ }
5438+
},
5439+
.chained = true,
5440+
.chain_id = ALC269_FIXUP_HEADSET_MODE
5441+
},
54325442
[ALC275_FIXUP_DELL_XPS] = {
54335443
.type = HDA_FIXUP_VERBS,
54345444
.v.verbs = (const struct hda_verb[]) {
@@ -5501,7 +5511,7 @@ static const struct hda_fixup alc269_fixups[] = {
55015511
.type = HDA_FIXUP_FUNC,
55025512
.v.func = alc298_fixup_speaker_volume,
55035513
.chained = true,
5504-
.chain_id = ALC298_FIXUP_DELL1_MIC_NO_PRESENCE,
5514+
.chain_id = ALC298_FIXUP_DELL_AIO_MIC_NO_PRESENCE,
55055515
},
55065516
[ALC256_FIXUP_DELL_INSPIRON_7559_SUBWOOFER] = {
55075517
.type = HDA_FIXUP_PINS,

0 commit comments

Comments
 (0)