platform/x86: hp-wmi: Fix error value for hp_wmi_tablet_state

Carlo Caione · gregkh · commit ce93b664540d · 2017-11-15T17:13:11.000+01:00
commit c7dfc2facbd69dad89b75e13c608da709668dcd0 upstream.

hp_wmi_tablet_state() fails to return the correct error code when
hp_wmi_perform_query() returns the HP WMI query specific error code
that is a positive value.

Signed-off-by: Carlo Caione &lt;carlo@endlessm.com&gt;
Signed-off-by: Darren Hart (VMware) &lt;dvhart@infradead.org&gt;
Cc: Philip Müller &lt;philm@manjaro.org&gt;
Signed-off-by: Greg Kroah-Hartman &lt;gregkh@linuxfoundation.org&gt;
diff --git a/drivers/platform/x86/hp-wmi.c b/drivers/platform/x86/hp-wmi.c
@@ -291,7 +291,7 @@ static int hp_wmi_tablet_state(void)
 	int ret = hp_wmi_perform_query(HPWMI_HARDWARE_QUERY, 0, &state,
 				       sizeof(state), sizeof(state));
 	if (ret)
-		return ret;
+		return -EINVAL;
 
 	return (state & 0x4) ? 1 : 0;
 }

Original file line number	Diff line number	Diff line change
`@@ -291,7 +291,7 @@ static int hp_wmi_tablet_state(void)`
`291`	`291`	`int ret = hp_wmi_perform_query(HPWMI_HARDWARE_QUERY, 0, &state,`
`292`	`292`	`sizeof(state), sizeof(state));`
`293`	`293`	`if (ret)`
`294`		`- return ret;`
	`294`	`+ return -EINVAL;`
`295`	`295`
`296`	`296`	`return (state & 0x4) ? 1 : 0;`
`297`	`297`	`}`