Skip to content

Commit cf09c7d

Browse files
groeckgregkh
authored andcommitted
usb: host: xhci-plat: Fix timeout on removal of hot pluggable xhci controllers
commit dcc7620cad5ad1326a78f4031a7bf4f0e5b42984 upstream. Upstream commit 98d74f9ceaef ("xhci: fix 10 second timeout on removal of PCI hotpluggable xhci controllers") fixes a problem with hot pluggable PCI xhci controllers which can result in excessive timeouts, to the point where the system reports a deadlock. The same problem is seen with hot pluggable xhci controllers using the xhci-plat driver, such as the driver used for Type-C ports on rk3399. Similar to hot-pluggable PCI controllers, the driver for this chip removes the xhci controller from the system when the Type-C cable is disconnected. The solution for PCI devices works just as well for non-PCI devices and avoids the problem. Signed-off-by: Guenter Roeck <linux@roeck-us.net> Signed-off-by: Mathias Nyman <mathias.nyman@linux.intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent 40c5634 commit cf09c7d

1 file changed

Lines changed: 2 additions & 0 deletions

File tree

drivers/usb/host/xhci-plat.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -213,6 +213,8 @@ static int xhci_plat_remove(struct platform_device *dev)
213213
struct xhci_hcd *xhci = hcd_to_xhci(hcd);
214214
struct clk *clk = xhci->clk;
215215

216+
xhci->xhc_state |= XHCI_STATE_REMOVING;
217+
216218
usb_remove_hcd(xhci->shared_hcd);
217219
usb_phy_shutdown(hcd->usb_phy);
218220

0 commit comments

Comments
 (0)