Skip to content

Commit d32ee70

Browse files
arndbgregkh
authored andcommitted
ARM: remove duplicate 'const' annotations'
commit 0527873b29b077fc8e656acd63e1866b429fef55 upstream. gcc-7 warns about some declarations that are more 'const' than necessary: arch/arm/mach-at91/pm.c:338:34: error: duplicate 'const' declaration specifier [-Werror=duplicate-decl-specifier] static const struct of_device_id const ramc_ids[] __initconst = { arch/arm/mach-bcm/bcm_kona_smc.c:36:34: error: duplicate 'const' declaration specifier [-Werror=duplicate-decl-specifier] static const struct of_device_id const bcm_kona_smc_ids[] __initconst = { arch/arm/mach-spear/time.c:207:34: error: duplicate 'const' declaration specifier [-Werror=duplicate-decl-specifier] static const struct of_device_id const timer_of_match[] __initconst = { arch/arm/mach-omap2/prm_common.c:714:34: error: duplicate 'const' declaration specifier [-Werror=duplicate-decl-specifier] static const struct of_device_id const omap_prcm_dt_match_table[] __initconst = { arch/arm/mach-omap2/vc.c:562:35: error: duplicate 'const' declaration specifier [-Werror=duplicate-decl-specifier] static const struct i2c_init_data const omap4_i2c_timing_data[] __initconst = { The ones in arch/arm were apparently all introduced accidentally by one commit that correctly marked a lot of variables as __initconst. Fixes: 19c233b ("ARM: appropriate __init annotation for const data") Acked-by: Alexandre Belloni <alexandre.belloni@free-electrons.com> Acked-by: Tony Lindgren <tony@atomide.com> Acked-by: Nicolas Pitre <nico@linaro.org> Acked-by: Florian Fainelli <f.fainelli@gmail.com> Acked-by: Viresh Kumar <viresh.kumar@linaro.org> Acked-by: Krzysztof Hałasa <khalasa@piap.pl> Signed-off-by: Arnd Bergmann <arnd@arndb.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent 7cad91f commit d32ee70

6 files changed

Lines changed: 6 additions & 6 deletions

File tree

arch/arm/mach-at91/pm.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -332,7 +332,7 @@ static void at91sam9_sdram_standby(void)
332332
at91_ramc_write(1, AT91_SDRAMC_LPR, saved_lpr1);
333333
}
334334

335-
static const struct of_device_id const ramc_ids[] __initconst = {
335+
static const struct of_device_id ramc_ids[] __initconst = {
336336
{ .compatible = "atmel,at91rm9200-sdramc", .data = at91rm9200_standby },
337337
{ .compatible = "atmel,at91sam9260-sdramc", .data = at91sam9_sdram_standby },
338338
{ .compatible = "atmel,at91sam9g45-ddramc", .data = at91_ddr_standby },

arch/arm/mach-bcm/bcm_kona_smc.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ struct bcm_kona_smc_data {
3333
unsigned result;
3434
};
3535

36-
static const struct of_device_id const bcm_kona_smc_ids[] __initconst = {
36+
static const struct of_device_id bcm_kona_smc_ids[] __initconst = {
3737
{.compatible = "brcm,kona-smc"},
3838
{.compatible = "bcm,kona-smc"}, /* deprecated name */
3939
{},

arch/arm/mach-cns3xxx/core.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -346,7 +346,7 @@ static struct usb_ohci_pdata cns3xxx_usb_ohci_pdata = {
346346
.power_off = csn3xxx_usb_power_off,
347347
};
348348

349-
static const struct of_dev_auxdata const cns3xxx_auxdata[] __initconst = {
349+
static const struct of_dev_auxdata cns3xxx_auxdata[] __initconst = {
350350
{ "intel,usb-ehci", CNS3XXX_USB_BASE, "ehci-platform", &cns3xxx_usb_ehci_pdata },
351351
{ "intel,usb-ohci", CNS3XXX_USB_OHCI_BASE, "ohci-platform", &cns3xxx_usb_ohci_pdata },
352352
{ "cavium,cns3420-ahci", CNS3XXX_SATA2_BASE, "ahci", NULL },

arch/arm/mach-omap2/prm_common.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -706,7 +706,7 @@ static struct omap_prcm_init_data scrm_data __initdata = {
706706
};
707707
#endif
708708

709-
static const struct of_device_id const omap_prcm_dt_match_table[] __initconst = {
709+
static const struct of_device_id omap_prcm_dt_match_table[] __initconst = {
710710
#ifdef CONFIG_SOC_AM33XX
711711
{ .compatible = "ti,am3-prcm", .data = &am3_prm_data },
712712
#endif

arch/arm/mach-omap2/vc.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -559,7 +559,7 @@ struct i2c_init_data {
559559
u8 hsscll_12;
560560
};
561561

562-
static const struct i2c_init_data const omap4_i2c_timing_data[] __initconst = {
562+
static const struct i2c_init_data omap4_i2c_timing_data[] __initconst = {
563563
{
564564
.load = 50,
565565
.loadbits = 0x3,

arch/arm/mach-spear/time.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -204,7 +204,7 @@ static void __init spear_clockevent_init(int irq)
204204
setup_irq(irq, &spear_timer_irq);
205205
}
206206

207-
static const struct of_device_id const timer_of_match[] __initconst = {
207+
static const struct of_device_id timer_of_match[] __initconst = {
208208
{ .compatible = "st,spear-timer", },
209209
{ },
210210
};

0 commit comments

Comments
 (0)