Skip to content

Commit d35f8fa

Browse files
xairygregkh
authored andcommitted
net/packet: fix overflow in check for priv area size
commit 2b6867c2ce76c596676bec7d2d525af525fdc6e2 upstream. Subtracting tp_sizeof_priv from tp_block_size and casting to int to check whether one is less then the other doesn't always work (both of them are unsigned ints). Compare them as is instead. Also cast tp_sizeof_priv to u64 before using BLK_PLUS_PRIV, as it can overflow inside BLK_PLUS_PRIV otherwise. Signed-off-by: Andrey Konovalov <andreyknvl@google.com> Acked-by: Eric Dumazet <edumazet@google.com> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent fd8bae3 commit d35f8fa

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

net/packet/af_packet.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4138,8 +4138,8 @@ static int packet_set_ring(struct sock *sk, union tpacket_req_u *req_u,
41384138
if (unlikely(!PAGE_ALIGNED(req->tp_block_size)))
41394139
goto out;
41404140
if (po->tp_version >= TPACKET_V3 &&
4141-
(int)(req->tp_block_size -
4142-
BLK_PLUS_PRIV(req_u->req3.tp_sizeof_priv)) <= 0)
4141+
req->tp_block_size <=
4142+
BLK_PLUS_PRIV((u64)req_u->req3.tp_sizeof_priv))
41434143
goto out;
41444144
if (unlikely(req->tp_frame_size < po->tp_hdrlen +
41454145
po->tp_reserve))

0 commit comments

Comments
 (0)