Skip to content

Commit d521e9c

Browse files
Jack Morgensteingregkh
authored andcommitted
net/mlx4_core: Eliminate warning messages for SRQ_LIMIT under SRIOV
[ Upstream commit 9577b174cd0323d287c994ef0891db71666d0765 ] When running SRIOV, warnings for SRQ LIMIT events flood the Hypervisor's message log when (correct, normally operating) apps use SRQ LIMIT events as a trigger to post WQEs to SRQs. Add more information to the existing debug printout for SRQ_LIMIT, and output the warning messages only for the SRQ CATAS ERROR event. Fixes: acba242 ("mlx4_core: Add wrapper functions and comm channel and slave event support to EQs") Fixes: e0debf9 ("mlx4_core: Reduce warning message for SRQ_LIMIT event to debug level") Signed-off-by: Jack Morgenstein <jackm@dev.mellanox.co.il> Signed-off-by: Tariq Toukan <tariqt@mellanox.com> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Sasha Levin <alexander.levin@verizon.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent 9837392 commit d521e9c

1 file changed

Lines changed: 14 additions & 9 deletions

File tree

  • drivers/net/ethernet/mellanox/mlx4

drivers/net/ethernet/mellanox/mlx4/eq.c

Lines changed: 14 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -542,8 +542,9 @@ static int mlx4_eq_int(struct mlx4_dev *dev, struct mlx4_eq *eq)
542542
break;
543543

544544
case MLX4_EVENT_TYPE_SRQ_LIMIT:
545-
mlx4_dbg(dev, "%s: MLX4_EVENT_TYPE_SRQ_LIMIT\n",
546-
__func__);
545+
mlx4_dbg(dev, "%s: MLX4_EVENT_TYPE_SRQ_LIMIT. srq_no=0x%x, eq 0x%x\n",
546+
__func__, be32_to_cpu(eqe->event.srq.srqn),
547+
eq->eqn);
547548
case MLX4_EVENT_TYPE_SRQ_CATAS_ERROR:
548549
if (mlx4_is_master(dev)) {
549550
/* forward only to slave owning the SRQ */
@@ -558,15 +559,19 @@ static int mlx4_eq_int(struct mlx4_dev *dev, struct mlx4_eq *eq)
558559
eq->eqn, eq->cons_index, ret);
559560
break;
560561
}
561-
mlx4_warn(dev, "%s: slave:%d, srq_no:0x%x, event: %02x(%02x)\n",
562-
__func__, slave,
563-
be32_to_cpu(eqe->event.srq.srqn),
564-
eqe->type, eqe->subtype);
562+
if (eqe->type ==
563+
MLX4_EVENT_TYPE_SRQ_CATAS_ERROR)
564+
mlx4_warn(dev, "%s: slave:%d, srq_no:0x%x, event: %02x(%02x)\n",
565+
__func__, slave,
566+
be32_to_cpu(eqe->event.srq.srqn),
567+
eqe->type, eqe->subtype);
565568

566569
if (!ret && slave != dev->caps.function) {
567-
mlx4_warn(dev, "%s: sending event %02x(%02x) to slave:%d\n",
568-
__func__, eqe->type,
569-
eqe->subtype, slave);
570+
if (eqe->type ==
571+
MLX4_EVENT_TYPE_SRQ_CATAS_ERROR)
572+
mlx4_warn(dev, "%s: sending event %02x(%02x) to slave:%d\n",
573+
__func__, eqe->type,
574+
eqe->subtype, slave);
570575
mlx4_slave_event(dev, slave, eqe);
571576
break;
572577
}

0 commit comments

Comments
 (0)