Skip to content

Commit e1db592

Browse files
ffainelligregkh
authored andcommitted
net: bgmac: Remove superflous netif_carrier_on()
commit 3894396e64994f31c3ef5c7e6f63dded0593e567 upstream. bgmac_open() calls phy_start() to initialize the PHY state machine, which will set the interface's carrier state accordingly, no need to force that as this could be conflicting with the PHY state determined by PHYLIB. Fixes: dd4544f ("bgmac: driver for GBit MAC core on BCMA bus") Signed-off-by: Florian Fainelli <f.fainelli@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Amit Pundir <amit.pundir@linaro.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent e66647f commit e1db592

1 file changed

Lines changed: 0 additions & 2 deletions

File tree

  • drivers/net/ethernet/broadcom

drivers/net/ethernet/broadcom/bgmac.c

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1308,8 +1308,6 @@ static int bgmac_open(struct net_device *net_dev)
13081308

13091309
phy_start(bgmac->phy_dev);
13101310

1311-
netif_carrier_on(net_dev);
1312-
13131311
netif_start_queue(net_dev);
13141312

13151313
return 0;

0 commit comments

Comments
 (0)