Skip to content

Commit e38a80f

Browse files
Brendan Jackmanpundiramit
authored andcommitted
UPSTREAM: sched/fair: Remove unnecessary comparison with -1
Since commit: 83a0a96 ("sched/fair: Leverage the idle state info when choosing the "idlest" cpu") find_idlest_group_cpu() (formerly find_idlest_cpu) no longer returns -1, so we can simplify the checking of the return value in find_idlest_cpu(). Change-Id: I98f4b9f178cd93a30408e024e608d36771764c7b Signed-off-by: Brendan Jackman <brendan.jackman@arm.com> Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org> Reviewed-by: Josef Bacik <jbacik@fb.com> Reviewed-by: Vincent Guittot <vincent.guittot@linaro.org> Cc: Dietmar Eggemann <dietmar.eggemann@arm.com> Cc: Josef Bacik <josef@toxicpanda.com> Cc: Linus Torvalds <torvalds@linux-foundation.org> Cc: Mike Galbraith <efault@gmx.de> Cc: Morten Rasmussen <morten.rasmussen@arm.com> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Thomas Gleixner <tglx@linutronix.de> Link: http://lkml.kernel.org/r/20171005114516.18617-3-brendan.jackman@arm.com Signed-off-by: Ingo Molnar <mingo@kernel.org> (cherry-picked-from commit e90381eaecf6 in tip:sched/core) Signed-off-by: Chris Redpath <chris.redpath@arm.com>
1 parent 15b467e commit e38a80f

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

kernel/sched/fair.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6156,7 +6156,7 @@ static inline int find_idlest_cpu(struct sched_domain *sd, struct task_struct *p
61566156
}
61576157

61586158
new_cpu = find_idlest_group_cpu(group, p, cpu);
6159-
if (new_cpu == -1 || new_cpu == cpu) {
6159+
if (new_cpu == cpu) {
61606160
/* Now try balancing at a lower domain level of cpu */
61616161
sd = sd->child;
61626162
continue;

0 commit comments

Comments
 (0)