Skip to content

Commit e421746

Browse files
arndbEduardo Valentin
authored andcommitted
Revert "thermal: qcom_spmi: allow compile test"
This just caused build errors: warning: (QCOM_SPMI_TEMP_ALARM) selects REGMAP_SPMI which has unmet direct dependencies (SPMI) drivers/built-in.o: In function `regmap_spmi_ext_gather_write': :(.text+0x609b0): undefined reference to `spmi_ext_register_write' :(.text+0x609f0): undefined reference to `spmi_ext_register_writel' While it's generally a good idea to allow compile testing, in this case, it just doesn't work, so reverting the patch that introduced the compile-test variant seems the most appropriate solution. Note that SPMI also has a 'depends on ARCH_QCOM || COMPILE_TEST' statement, so we should be able to enable SPMI on all architectures for compile testing already. Signed-off-by: Arnd Bergmann <arnd@arndb.de> Fixes: cb7fb4d ("thermal: qcom_spmi: allow compile test") Signed-off-by: Eduardo Valentin <edubezval@gmail.com>
1 parent 84f0e49 commit e421746

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

drivers/thermal/Kconfig

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -382,7 +382,7 @@ endmenu
382382

383383
config QCOM_SPMI_TEMP_ALARM
384384
tristate "Qualcomm SPMI PMIC Temperature Alarm"
385-
depends on OF && (SPMI || COMPILE_TEST) && IIO
385+
depends on OF && SPMI && IIO
386386
select REGMAP_SPMI
387387
help
388388
This enables a thermal sysfs driver for Qualcomm plug-and-play (QPNP)

0 commit comments

Comments
 (0)