Skip to content

Commit e59d911

Browse files
tmlindgregkh
authored andcommitted
mfd: omap-usb-tll: Fix inverted bit use for USB TLL mode
commit 8b8a84c54aff4256d592dc18346c65ecf6811b45 upstream. Commit 16fa3dc ("mfd: omap-usb-tll: HOST TLL platform driver") added support for USB TLL, but uses OMAP_TLL_CHANNEL_CONF_ULPINOBITSTUFF bit the wrong way. The comments in the code are correct, but the inverted use of OMAP_TLL_CHANNEL_CONF_ULPINOBITSTUFF causes the register to be enabled instead of disabled unlike what the comments say. Without this change the Wrigley 3G LTE modem on droid 4 EHCI bus can be only pinged few times before it stops responding. Fixes: 16fa3dc ("mfd: omap-usb-tll: HOST TLL platform driver") Signed-off-by: Tony Lindgren <tony@atomide.com> Acked-by: Roger Quadros <rogerq@ti.com> Signed-off-by: Lee Jones <lee.jones@linaro.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent 93d022e commit e59d911

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

drivers/mfd/omap-usb-tll.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -375,8 +375,8 @@ int omap_tll_init(struct usbhs_omap_platform_data *pdata)
375375
* and use SDR Mode
376376
*/
377377
reg &= ~(OMAP_TLL_CHANNEL_CONF_UTMIAUTOIDLE
378-
| OMAP_TLL_CHANNEL_CONF_ULPINOBITSTUFF
379378
| OMAP_TLL_CHANNEL_CONF_ULPIDDRMODE);
379+
reg |= OMAP_TLL_CHANNEL_CONF_ULPINOBITSTUFF;
380380
} else if (pdata->port_mode[i] ==
381381
OMAP_EHCI_PORT_MODE_HSIC) {
382382
/*

0 commit comments

Comments
 (0)