Skip to content

Commit e71c7ba

Browse files
jhovoldgregkh
authored andcommitted
USB: serial: io_ti: fix NULL-deref in interrupt callback
commit 0b1d250afb8eb9d65afb568bac9b9f9253a82b49 upstream. Fix a NULL-pointer dereference in the interrupt callback should a malicious device send data containing a bad port number by adding the missing sanity check. Fixes: 1da177e ("Linux-2.6.12-rc2") Signed-off-by: Johan Hovold <johan@kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent 6498086 commit e71c7ba

1 file changed

Lines changed: 6 additions & 0 deletions

File tree

drivers/usb/serial/io_ti.c

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1674,6 +1674,12 @@ static void edge_interrupt_callback(struct urb *urb)
16741674
function = TIUMP_GET_FUNC_FROM_CODE(data[0]);
16751675
dev_dbg(dev, "%s - port_number %d, function %d, info 0x%x\n", __func__,
16761676
port_number, function, data[1]);
1677+
1678+
if (port_number >= edge_serial->serial->num_ports) {
1679+
dev_err(dev, "bad port number %d\n", port_number);
1680+
goto exit;
1681+
}
1682+
16771683
port = edge_serial->serial->port[port_number];
16781684
edge_port = usb_get_serial_port_data(port);
16791685
if (!edge_port) {

0 commit comments

Comments
 (0)