Skip to content

Commit e9a2ce2

Browse files
tpetazzonigregkh
authored andcommitted
ARM: mvebu: fix HW I/O coherency related deadlocks
commit c5379ba8fccd99d5f99632c789f0393d84a57805 upstream. Until now, our understanding for HW I/O coherency to work on the Cortex-A9 based Marvell SoC was that only the PCIe regions should be mapped strongly-ordered. However, we were still encountering some deadlocks, especially when testing the CESA crypto engine. After checking with the HW designers, it was concluded that all the MMIO registers should be mapped as strongly ordered for the HW I/O coherency mechanism to work properly. This fixes some easy to reproduce deadlocks with the CESA crypto engine driver (dmcrypt on a sufficiently large disk partition). Tested-by: Terry Stockert <stockert@inkblotadmirer.me> Tested-by: Romain Perier <romain.perier@free-electrons.com> Cc: Terry Stockert <stockert@inkblotadmirer.me> Cc: Romain Perier <romain.perier@free-electrons.com> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> Signed-off-by: Gregory CLEMENT <gregory.clement@free-electrons.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent e4ad472 commit e9a2ce2

1 file changed

Lines changed: 8 additions & 14 deletions

File tree

arch/arm/mach-mvebu/coherency.c

Lines changed: 8 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -162,22 +162,16 @@ static void __init armada_370_coherency_init(struct device_node *np)
162162
}
163163

164164
/*
165-
* This ioremap hook is used on Armada 375/38x to ensure that PCIe
166-
* memory areas are mapped as MT_UNCACHED instead of MT_DEVICE. This
167-
* is needed as a workaround for a deadlock issue between the PCIe
168-
* interface and the cache controller.
165+
* This ioremap hook is used on Armada 375/38x to ensure that all MMIO
166+
* areas are mapped as MT_UNCACHED instead of MT_DEVICE. This is
167+
* needed for the HW I/O coherency mechanism to work properly without
168+
* deadlock.
169169
*/
170170
static void __iomem *
171-
armada_pcie_wa_ioremap_caller(phys_addr_t phys_addr, size_t size,
172-
unsigned int mtype, void *caller)
171+
armada_wa_ioremap_caller(phys_addr_t phys_addr, size_t size,
172+
unsigned int mtype, void *caller)
173173
{
174-
struct resource pcie_mem;
175-
176-
mvebu_mbus_get_pcie_mem_aperture(&pcie_mem);
177-
178-
if (pcie_mem.start <= phys_addr && (phys_addr + size) <= pcie_mem.end)
179-
mtype = MT_UNCACHED;
180-
174+
mtype = MT_UNCACHED;
181175
return __arm_ioremap_caller(phys_addr, size, mtype, caller);
182176
}
183177

@@ -186,7 +180,7 @@ static void __init armada_375_380_coherency_init(struct device_node *np)
186180
struct device_node *cache_dn;
187181

188182
coherency_cpu_base = of_iomap(np, 0);
189-
arch_ioremap_caller = armada_pcie_wa_ioremap_caller;
183+
arch_ioremap_caller = armada_wa_ioremap_caller;
190184

191185
/*
192186
* We should switch the PL310 to I/O coherency mode only if

0 commit comments

Comments
 (0)