Skip to content

Commit eb7f316

Browse files
KAZUMIZUgregkh
authored andcommitted
usb: renesas_usbhs: Fix DMAC sequence for receiving zero-length packet
commit 29c7f3e68eec4ae94d85ad7b5dfdafdb8089f513 upstream. The DREQE bit of the DnFIFOSEL should be set to 1 after the DE bit of USB-DMAC on R-Car SoCs is set to 1 after the USB-DMAC received a zero-length packet. Otherwise, a transfer completion interruption of USB-DMAC doesn't happen. Even if the driver changes the sequence, normal operations (transmit/receive without zero-length packet) will not cause any side-effects. So, this patch fixes the sequence anyway. Signed-off-by: Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com> [shimoda: revise the commit log] Fixes: e73a989 ("usb: renesas_usbhs: add DMAEngine support") Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent 6a92b99 commit eb7f316

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

  • drivers/usb/renesas_usbhs

drivers/usb/renesas_usbhs/fifo.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -858,9 +858,9 @@ static void xfer_work(struct work_struct *work)
858858
fifo->name, usbhs_pipe_number(pipe), pkt->length, pkt->zero);
859859

860860
usbhs_pipe_running(pipe, 1);
861-
usbhsf_dma_start(pipe, fifo);
862861
usbhs_pipe_set_trans_count_if_bulk(pipe, pkt->trans);
863862
dma_async_issue_pending(chan);
863+
usbhsf_dma_start(pipe, fifo);
864864
usbhs_pipe_enable(pipe);
865865

866866
xfer_work_end:

0 commit comments

Comments
 (0)