irda: do not leak initialized list.dev to userspace

Colin Ian King · gregkh · commit eece6c91dd33 · 2017-08-30T10:19:21.000+02:00
[ Upstream commit b024d949a3c24255a7ef1a470420eb478949aa4c ]

list.dev has not been initialized and so the copy_to_user is copying
data from the stack back to user space which is a potential
information leak. Fix this ensuring all of list is initialized to
zero.

Detected by CoverityScan, CID#1357894 ("Uninitialized scalar variable")

Signed-off-by: Colin Ian King &lt;colin.king@canonical.com&gt;
Signed-off-by: David S. Miller &lt;davem@davemloft.net&gt;
Signed-off-by: Greg Kroah-Hartman &lt;gregkh@linuxfoundation.org&gt;
diff --git a/net/irda/af_irda.c b/net/irda/af_irda.c
@@ -2227,7 +2227,7 @@ static int irda_getsockopt(struct socket *sock, int level, int optname,
 {
 	struct sock *sk = sock->sk;
 	struct irda_sock *self = irda_sk(sk);
-	struct irda_device_list list;
+	struct irda_device_list list = { 0 };
 	struct irda_device_info *discoveries;
 	struct irda_ias_set *	ias_opt;	/* IAS get/query params */
 	struct ias_object *	ias_obj;	/* Object in IAS */

Original file line number	Diff line number	Diff line change
`@@ -2227,7 +2227,7 @@ static int irda_getsockopt(struct socket *sock, int level, int optname,`
`2227`	`2227`	`{`
`2228`	`2228`	`struct sock *sk = sock->sk;`
`2229`	`2229`	`struct irda_sock *self = irda_sk(sk);`
`2230`		`- struct irda_device_list list;`
	`2230`	`+ struct irda_device_list list = { 0 };`
`2231`	`2231`	`struct irda_device_info *discoveries;`
`2232`	`2232`	`struct irda_ias_set * ias_opt; /* IAS get/query params */`
`2233`	`2233`	`struct ias_object * ias_obj; /* Object in IAS */`