padata: free correct variable

zx2c4 · gregkh · commit f08bc4d63377 · 2017-05-20T14:27:02.000+02:00
commit 07a77929ba672d93642a56dc2255dd21e6e2290b upstream.

The author meant to free the variable that was just allocated, instead
of the one that failed to be allocated, but made a simple typo. This
patch rectifies that.

Signed-off-by: Jason A. Donenfeld &lt;Jason@zx2c4.com&gt;
Signed-off-by: Herbert Xu &lt;herbert@gondor.apana.org.au&gt;
Signed-off-by: Greg Kroah-Hartman &lt;gregkh@linuxfoundation.org&gt;
diff --git a/kernel/padata.c b/kernel/padata.c
@@ -357,7 +357,7 @@ static int padata_setup_cpumasks(struct parallel_data *pd,
 
 	cpumask_and(pd->cpumask.pcpu, pcpumask, cpu_online_mask);
 	if (!alloc_cpumask_var(&pd->cpumask.cbcpu, GFP_KERNEL)) {
-		free_cpumask_var(pd->cpumask.cbcpu);
+		free_cpumask_var(pd->cpumask.pcpu);
 		return -ENOMEM;
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -357,7 +357,7 @@ static int padata_setup_cpumasks(struct parallel_data *pd,`
`357`	`357`
`358`	`358`	`cpumask_and(pd->cpumask.pcpu, pcpumask, cpu_online_mask);`
`359`	`359`	`if (!alloc_cpumask_var(&pd->cpumask.cbcpu, GFP_KERNEL)) {`
`360`		`- free_cpumask_var(pd->cpumask.cbcpu);`
	`360`	`+ free_cpumask_var(pd->cpumask.pcpu);`
`361`	`361`	`return -ENOMEM;`
`362`	`362`	`}`
`363`	`363`