Skip to content

Commit f0cd701

Browse files
Dan Carpentergregkh
authored andcommitted
scsi: sg: off by one in sg_ioctl()
commit bd46fc406b30d1db1aff8dabaff8d18bb423fdcf upstream. If "val" is SG_MAX_QUEUE then we are one element beyond the end of the "rinfo" array so the > should be >=. Fixes: 109bade9c625 ("scsi: sg: use standard lists for sg_requests") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Acked-by: Douglas Gilbert <dgilbert@interlog.com> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent 3682e0c commit f0cd701

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

drivers/scsi/sg.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1041,7 +1041,7 @@ sg_ioctl(struct file *filp, unsigned int cmd_in, unsigned long arg)
10411041
read_lock_irqsave(&sfp->rq_list_lock, iflags);
10421042
val = 0;
10431043
list_for_each_entry(srp, &sfp->rq_list, entry) {
1044-
if (val > SG_MAX_QUEUE)
1044+
if (val >= SG_MAX_QUEUE)
10451045
break;
10461046
memset(&rinfo[val], 0, SZ_SG_REQ_INFO);
10471047
rinfo[val].req_state = srp->done + 1;

0 commit comments

Comments
 (0)