Skip to content

Commit f940011

Browse files
Miklos Szeredigregkh
authored andcommitted
vfs: fix uninitialized flags in splice_to_pipe()
commit 5a81e6a171cdbd1fa8bc1fdd80c23d3d71816fac upstream. Flags (PIPE_BUF_FLAG_PACKET, PIPE_BUF_FLAG_GIFT) could remain on the unused part of the pipe ring buffer. Previously splice_to_pipe() left the flags value alone, which could result in incorrect behavior. Uninitialized flags appears to have been there from the introduction of the splice syscall. Signed-off-by: Miklos Szeredi <mszeredi@redhat.com> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent c50b74d commit f940011

1 file changed

Lines changed: 1 addition & 0 deletions

File tree

fs/splice.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -211,6 +211,7 @@ ssize_t splice_to_pipe(struct pipe_inode_info *pipe,
211211
buf->len = spd->partial[page_nr].len;
212212
buf->private = spd->partial[page_nr].private;
213213
buf->ops = spd->ops;
214+
buf->flags = 0;
214215
if (spd->flags & SPLICE_F_GIFT)
215216
buf->flags |= PIPE_BUF_FLAG_GIFT;
216217

0 commit comments

Comments
 (0)