ALSA: firewire-tascam: Fix to handle error from initialization of stream data

takaswie · gregkh · commit fa48a1607580 · 2017-01-15T13:41:36.000+01:00
commit 6a2a2f45560a9cb7bc49820883b042e44f83726c upstream. This module has a bug not to return error code in a case that data structure for transmitted packets fails to be initialized. This commit fixes the bug. Fixes: 35efa5c ("ALSA: firewire-tascam: add streaming functionality") Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp> Signed-off-by: Takashi Iwai <tiwai@suse.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
diff --git a/sound/firewire/tascam/tascam-stream.c b/sound/firewire/tascam/tascam-stream.c
@@ -343,7 +343,7 @@ int snd_tscm_stream_init_duplex(struct snd_tscm *tscm)
 	if (err < 0)
 		amdtp_stream_destroy(&tscm->rx_stream);
 
-	return 0;
+	return err;
 }
 
 /* At bus reset, streaming is stopped and some registers are clear. */

Original file line number	Diff line number	Diff line change
`@@ -343,7 +343,7 @@ int snd_tscm_stream_init_duplex(struct snd_tscm *tscm)`
`343`	`343`	`if (err < 0)`
`344`	`344`	`amdtp_stream_destroy(&tscm->rx_stream);`
`345`	`345`
`346`		`- return 0;`
	`346`	`+ return err;`
`347`	`347`	`}`
`348`	`348`
`349`	`349`	`/* At bus reset, streaming is stopped and some registers are clear. */`