Skip to content

Commit fa57125

Browse files
edumazetgregkh
authored andcommitted
net: skb_needs_check() accepts CHECKSUM_NONE for tx
commit 6e7bc478c9a006c701c14476ec9d389a484b4864 upstream. My recent change missed fact that UFO would perform a complete UDP checksum before segmenting in frags. In this case skb->ip_summed is set to CHECKSUM_NONE. We need to add this valid case to skb_needs_check() Fixes: b2504a5dbef3 ("net: reduce skb_warn_bad_offload() noise") Signed-off-by: Eric Dumazet <edumazet@google.com> Cc: Willem de Bruijn <willemb@google.com> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent fa77731 commit fa57125

1 file changed

Lines changed: 4 additions & 3 deletions

File tree

net/core/dev.c

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2550,9 +2550,10 @@ EXPORT_SYMBOL(skb_mac_gso_segment);
25502550
static inline bool skb_needs_check(struct sk_buff *skb, bool tx_path)
25512551
{
25522552
if (tx_path)
2553-
return skb->ip_summed != CHECKSUM_PARTIAL;
2554-
else
2555-
return skb->ip_summed == CHECKSUM_NONE;
2553+
return skb->ip_summed != CHECKSUM_PARTIAL &&
2554+
skb->ip_summed != CHECKSUM_NONE;
2555+
2556+
return skb->ip_summed == CHECKSUM_NONE;
25562557
}
25572558

25582559
/**

0 commit comments

Comments
 (0)