Skip to content

Commit fa90f02

Browse files
tomasz1986gregkh
authored andcommitted
cpufreq: conservative: Allow down_threshold to take values from 1 to 10
commit b8e11f7d2791bd9320be1c6e772a60b2aa093e45 upstream. Commit 27ed3cd (cpufreq: conservative: Fix the logic in frequency decrease checking) removed the 10 point substraction when comparing the load against down_threshold but did not remove the related limit for the down_threshold value. As a result, down_threshold lower than 11 is not allowed even though values from 1 to 10 do work correctly too. The comment ("cannot be lower than 11 otherwise freq will not fall") also does not apply after removing the substraction. For this reason, allow down_threshold to take any value from 1 to 99 and fix the related comment. Fixes: 27ed3cd (cpufreq: conservative: Fix the logic in frequency decrease checking) Signed-off-by: Tomasz Wilczyński <twilczynski@naver.com> Acked-by: Viresh Kumar <viresh.kumar@linaro.org> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent 58ab7a8 commit fa90f02

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

drivers/cpufreq/cpufreq_conservative.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -212,8 +212,8 @@ static ssize_t store_down_threshold(struct dbs_data *dbs_data, const char *buf,
212212
int ret;
213213
ret = sscanf(buf, "%u", &input);
214214

215-
/* cannot be lower than 11 otherwise freq will not fall */
216-
if (ret != 1 || input < 11 || input > 100 ||
215+
/* cannot be lower than 1 otherwise freq will not fall */
216+
if (ret != 1 || input < 1 || input > 100 ||
217217
input >= cs_tuners->up_threshold)
218218
return -EINVAL;
219219

0 commit comments

Comments
 (0)