Skip to content

Commit fff544c

Browse files
jbeulichgregkh
authored andcommitted
xen/manage: correct return value check on xenbus_scanf()
[ Upstream commit 4fed1b125eb6252bde478665fc05d4819f774fa8 ] A negative return value indicates an error; in fact the function at present won't ever return zero. Signed-off-by: Jan Beulich <jbeulich@suse.com> Reviewed-by: Juergen Gross <jgross@suse.com> Signed-off-by: Boris Ostrovsky <boris.ostrovsky@oracle.com> Signed-off-by: Sasha Levin <alexander.levin@verizon.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent 762d076 commit fff544c

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

drivers/xen/manage.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -275,7 +275,7 @@ static void sysrq_handler(struct xenbus_watch *watch, const char **vec,
275275
err = xenbus_transaction_start(&xbt);
276276
if (err)
277277
return;
278-
if (!xenbus_scanf(xbt, "control", "sysrq", "%c", &sysrq_key)) {
278+
if (xenbus_scanf(xbt, "control", "sysrq", "%c", &sysrq_key) < 0) {
279279
pr_err("Unable to read sysrq code in control/sysrq\n");
280280
xenbus_transaction_end(xbt, 1);
281281
return;

0 commit comments

Comments
 (0)