feat(builder): add server_plan parameter (#185)

Author: kangasta

.web-docs/components/builder/upcloud/README.md

@@ -36,6 +36,8 @@ The upcloud builder is used to generate storage templates on UpCloud.
 
 - `token` (string) - The API token to use when interfacing with the UpCloud API. This is mutually exclusive with username and password.
 
+- `server_plan` (string) - Server plan to use for the builder server. Defaults to `1xCPU-2GB`.
+
 - `storage_name` (string) - The name of the storage that will be used to find the first matching storage in the list of existing templates.
 
   Note that `storage_uuid` parameter has higher priority. You should use either `storage_uuid` or `storage_name` for not strict matching (e.g "ubuntu server 24.04").

CHANGELOG.md

@@ -5,6 +5,10 @@ See updating [Changelog example here](https://keepachangelog.com/en/1.0.0/)
 
 ## [Unreleased]
 
+### Added
+
+- `server_plan` parameter to builder configuration for selecting server plan to use during build.
+
 ## [1.9.2] - 2025-10-16
 
 ### Changed

builder/upcloud/artifact.go

@@ -32,7 +32,7 @@ func (a *Artifact) Files() []string {
 }
 
 func (a *Artifact) Id() string { //nolint:revive // method is required by packer-plugin-sdk
-	result := []string{}
+	result := make([]string, 0, len(a.Templates))
 	for _, t := range a.Templates {
 		result = append(result, t.UUID)
 	}

builder/upcloud/artifact_test.go

@@ -24,7 +24,7 @@ func TestArtifact_Id(t *testing.T) {
 	uuid2 := "some-uuid-2"
 	expected := fmt.Sprintf("%s,%s", uuid1, uuid2)
 
-	templates := []*upcloud.Storage{}
+	templates := make([]*upcloud.Storage, 0, 2)
 	templates = append(templates, &upcloud.Storage{UUID: uuid1}, &upcloud.Storage{UUID: uuid2})
 
 	a := &Artifact{Templates: templates}
@@ -39,7 +39,7 @@ func TestArtifact_String(t *testing.T) {
 	t.Parallel()
 	expected := `Storage template created, UUID: some-uuid`
 
-	templates := []*upcloud.Storage{}
+	templates := make([]*upcloud.Storage, 0, 1)
 	templates = append(templates, &upcloud.Storage{UUID: "some-uuid"})
 
 	a := &Artifact{Templates: templates}
@@ -52,7 +52,7 @@ func TestArtifact_String(t *testing.T) {
 
 func TestArtifact_Metadata(t *testing.T) {
 	t.Parallel()
-	templates := []*upcloud.Storage{}
+	templates := make([]*upcloud.Storage, 0, 2)
 	templates = append(templates,
 		&upcloud.Storage{
 			UUID:  "some-uuid",

builder/upcloud/builder_acc_test.go

@@ -38,8 +38,8 @@ var testBuilderStorageName string
 //go:embed test-fixtures/json/networking.json
 var testBuilderNetworking string
 
-//go:embed test-fixtures/json/basic_standard_tier.json
-var testBuilderBasicStandardTier string
+//go:embed test-fixtures/json/plan_and_tier.json
+var testBuilderPlanAndTier string
 
 func TestBuilderAcc_default(t *testing.T) {
 	t.Parallel()
@@ -78,12 +78,12 @@ func TestBuilderAcc_storageName(t *testing.T) {
 	acctest.TestPlugin(t, testCase)
 }
 
-func TestBuilderAcc_standardTier(t *testing.T) {
+func TestBuilderAcc_planAndTier(t *testing.T) {
 	t.Parallel()
 	testAccPreCheck(t)
 	testCase := &acctest.PluginTestCase{
 		Name:     t.Name(),
-		Template: testBuilderBasicStandardTier,
+		Template: testBuilderPlanAndTier,
 		Check:    checkTestResult(t),
 		Teardown: teardown(t, t.Name()),
 	}
@@ -107,6 +107,9 @@ func TestBuilderAcc_networking(t *testing.T) {
 //go:embed test-fixtures/hcl2/basic.pkr.hcl
 var testBuildBasicHcl string
 
+//go:embed test-fixtures/hcl2/plan_and_tier.pkr.hcl
+var testBuilderPlanAndTierHcl string
+
 //go:embed test-fixtures/hcl2/storage-uuid.pkr.hcl
 var testBuilderStorageUUIDHcl string
 
@@ -128,6 +131,18 @@ func TestBuilderAcc_default_hcl(t *testing.T) {
 	acctest.TestPlugin(t, testCase)
 }
 
+func TestBuilderAcc_planAndTier_hcl(t *testing.T) {
+	t.Parallel()
+	testAccPreCheck(t)
+	testCase := &acctest.PluginTestCase{
+		Name:     t.Name(),
+		Template: testBuilderPlanAndTierHcl,
+		Check:    checkTestResult(t),
+		Teardown: teardown(t, t.Name()),
+	}
+	acctest.TestPlugin(t, testCase)
+}
+
 func TestBuilderAcc_storageUuid_hcl(t *testing.T) {
 	t.Parallel()
 	testAccPreCheck(t)
@@ -152,7 +167,7 @@ func TestBuilderAcc_storageName_hcl(t *testing.T) {
 	acctest.TestPlugin(t, testCase)
 }
 
-func TestBuilderAcc_network_interfaces(t *testing.T) {
+func TestBuilderAcc_network_interfaces_hcl(t *testing.T) {
 	t.Parallel()
 	testAccPreCheck(t)
 	testCase := &acctest.PluginTestCase{

builder/upcloud/config.go

@@ -74,6 +74,9 @@ type Config struct {
 	// The zone in which the server and template should be created (e.g. nl-ams1).
 	Zone string `mapstructure:"zone" required:"true"`
 
+	// Server plan to use for the builder server. Defaults to `1xCPU-2GB`.
+	ServerPlan string `mapstructure:"server_plan"`
+
 	// The UUID of the storage you want to use as a template when creating the server.
 	//
 	// Optionally use `storage_name` parameter to find matching storage

builder/upcloud/config.hcl2spec.go

@@ -93,6 +93,7 @@ func (s *StepCreateServer) createServer(ctx context.Context, ui packer.Ui, drv d
 	}
 
 	response, err := drv.CreateServer(ctx, &driver.ServerOpts{
+		ServerPlan:   s.Config.ServerPlan,
 		StorageUUID:  storage.UUID,
 		StorageSize:  s.Config.StorageSize,
 		Zone:         s.Config.Zone,

builder/upcloud/step_create_server.go

@@ -1,9 +1,10 @@
 source "upcloud" "standard-tier" {
+  server_plan  = "2xCPU-4GB"
   storage_uuid = "01000000-0000-4000-8000-000150020100" # Rocky Linux 9
-  zone         = "pl-waw1"
   storage_tier = "standard"
+  zone         = "pl-waw1"
 }
 
 build {
   sources = ["source.upcloud.standard-tier"]
-} 
+}

…st-fixtures/hcl2/basic_standard_tier.hcl …test-fixtures/hcl2/plan_and_tier.pkr.hclbuilder/upcloud/test-fixtures/hcl2/basic_standard_tier.hcl renamed to builder/upcloud/test-fixtures/hcl2/plan_and_tier.pkr.hcl builder/upcloud/test-fixtures/hcl2/basic_standard_tier.hcl renamed to builder/upcloud/test-fixtures/hcl2/plan_and_tier.pkr.hcl

@@ -2,6 +2,7 @@
     "builders": [{
         "type": "upcloud",
         "zone": "nl-ams1",
+        "server_plan": "2xCPU-4GB",
         "storage_uuid": "01000000-0000-4000-8000-000150020100",
         "storage_tier": "standard"
     }]