chore: prealloc slices

Author: kangasta

builder/upcloud/artifact.go

@@ -32,7 +32,7 @@ func (a *Artifact) Files() []string {
 }
 
 func (a *Artifact) Id() string { //nolint:revive // method is required by packer-plugin-sdk
-	result := []string{}
+	result := make([]string, 0, len(a.Templates))
 	for _, t := range a.Templates {
 		result = append(result, t.UUID)
 	}

builder/upcloud/artifact_test.go

@@ -24,7 +24,7 @@ func TestArtifact_Id(t *testing.T) {
 	uuid2 := "some-uuid-2"
 	expected := fmt.Sprintf("%s,%s", uuid1, uuid2)
 
-	templates := []*upcloud.Storage{}
+	templates := make([]*upcloud.Storage, 0, 2)
 	templates = append(templates, &upcloud.Storage{UUID: uuid1}, &upcloud.Storage{UUID: uuid2})
 
 	a := &Artifact{Templates: templates}
@@ -39,7 +39,7 @@ func TestArtifact_String(t *testing.T) {
 	t.Parallel()
 	expected := `Storage template created, UUID: some-uuid`
 
-	templates := []*upcloud.Storage{}
+	templates := make([]*upcloud.Storage, 0, 1)
 	templates = append(templates, &upcloud.Storage{UUID: "some-uuid"})
 
 	a := &Artifact{Templates: templates}
@@ -52,7 +52,7 @@ func TestArtifact_String(t *testing.T) {
 
 func TestArtifact_Metadata(t *testing.T) {
 	t.Parallel()
-	templates := []*upcloud.Storage{}
+	templates := make([]*upcloud.Storage, 0, 2)
 	templates = append(templates,
 		&upcloud.Storage{
 			UUID:  "some-uuid",

builder/upcloud/utils.go

@@ -63,9 +63,9 @@ func sshHostCallback(state multistep.StateBag) (string, error) {
 }
 
 func convertNetworkTypes(rawNetworking []NetworkInterface) []request.CreateServerInterface {
-	networking := []request.CreateServerInterface{}
+	networking := make([]request.CreateServerInterface, 0, len(rawNetworking))
 	for _, iface := range rawNetworking {
-		ips := []request.CreateServerIPAddress{}
+		ips := make([]request.CreateServerIPAddress, 0, len(iface.IPAddresses))
 		for _, ip := range iface.IPAddresses {
 			ips = append(ips, request.CreateServerIPAddress{Family: ip.Family, Address: ip.Address})
 		}

post-processor/upcloud-import/config_test.go

@@ -60,8 +60,8 @@ func TestNewConfig_BothAuthMethods(t *testing.T) {
 
 	assert.NoError(t, err)
 	assert.Equal(t, "test-api-token", c.Token)
-	assert.Equal(t, "", c.Username)
-	assert.Equal(t, "", c.Password)
+	assert.Empty(t, c.Username)
+	assert.Empty(t, c.Password)
 }
 
 func TestNewConfig_NoAuthMethods(t *testing.T) {