Skip to content

Commit 626564c

Browse files
authored
chore: run bucket CORS configuration tests against moto (#23)
1 parent 3a5063f commit 626564c

File tree

2 files changed

+1
-4
lines changed

2 files changed

+1
-4
lines changed

.github/workflows/test.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,7 @@ jobs:
107107
OBJSTO_ENDPOINT: http://localhost:5000
108108
OBJSTO_REGION: us-east-1
109109
run: |
110-
docker run -d -e MOTO_S3_ALLOW_CROSSACCOUNT_ACCESS=false -e MOTO_IAM_LOAD_MANAGED_POLICIES=false -e MOTO_EC2_LOAD_DEFAULT_AMIS=false -p 5000:5000 motoserver/moto:5.0.21
110+
docker run -d -e MOTO_DISABLE_GLOBAL_CORS=yes -e MOTO_S3_ALLOW_CROSSACCOUNT_ACCESS=false -e MOTO_IAM_LOAD_MANAGED_POLICIES=false -e MOTO_EC2_LOAD_DEFAULT_AMIS=false -p 5000:5000 motoserver/moto:5.0.28
111111
112112
go test -v -cover ./internal/provider/
113113
timeout-minutes: 10

internal/provider/bucket_cors_configuration_test.go

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -61,9 +61,6 @@ func TestAccBucketCORSConfigurationResource(t *testing.T) {
6161
if testTargetIs("Minio") {
6262
t.Skip("Skipping CORS configuration tests because target object storage is Minio which does not support configuring CORS settings for buckets.")
6363
}
64-
if testTargetIs("moto") {
65-
t.Skip("Skipping CORS configuration tests because target object storage is moto which configures wildcard CORS that overrides empty bucket CORS. See https://github.com/getmoto/moto/issues/8410")
66-
}
6764

6865
bucket_name := withSuffix("bucket-cors-configuration")
6966

0 commit comments

Comments
 (0)