test: validate lifecycle policy rule with newer_noncurrent_versions

Author: kangasta

.github/workflows/test.yml

@@ -8,6 +8,7 @@ on:
     - '**.go'
     - 'go.mod'
     - 'go.sum'
+    - 'internal/provider/testdata/*.tf'
     - '.github/workflows/test.yml'
   push:
     branches:
@@ -16,6 +17,7 @@ on:
     - '**.go'
     - 'go.mod'
     - 'go.sum'
+    - 'internal/provider/testdata/*.tf'
     - '.github/workflows/test.yml'
 
 permissions:
@@ -51,6 +53,7 @@ jobs:
         cli:
           - terraform
           - tofu
+      fail-fast: false
     needs: build
     runs-on: ubuntu-latest
     timeout-minutes: 15

internal/provider/bucket_lifecycle_configuration.go

@@ -8,7 +8,6 @@ import (
 	awshttp "github.com/aws/aws-sdk-go-v2/aws/transport/http"
 	"github.com/aws/aws-sdk-go-v2/service/s3"
 	s3_types "github.com/aws/aws-sdk-go-v2/service/s3/types"
-	"github.com/hashicorp/terraform-plugin-framework-validators/int32validator"
 	"github.com/hashicorp/terraform-plugin-framework-validators/int64validator"
 	"github.com/hashicorp/terraform-plugin-framework-validators/listvalidator"
 	"github.com/hashicorp/terraform-plugin-framework-validators/objectvalidator"
@@ -266,11 +265,6 @@ func (r *BucketLifecycleConfigurationResource) Schema(ctx context.Context, req r
 								"newer_noncurrent_versions": schema.Int32Attribute{
 									Optional:            true,
 									MarkdownDescription: "The number of newer noncurrent versions.",
-									Validators: []validator.Int32{
-										int32validator.ConflictsWith(
-											path.MatchRelative().AtParent().AtName("noncurrent_days"),
-										),
-									},
 								},
 								"noncurrent_days": schema.Int32Attribute{
 									Optional:            true,

internal/provider/testdata/bucket_lifecycle.tf

@@ -10,6 +10,19 @@ resource "objsto_bucket" "this" {
 resource "objsto_bucket_lifecycle_configuration" "this" {
   bucket = objsto_bucket.this.bucket
 
+  rule {
+    id = "Expire non-current versions after 3 newer versions"
+
+    filter {
+      prefix = "test/"
+    }
+
+    noncurrent_version_expiration {
+      noncurrent_days = 1
+      newer_noncurrent_versions = 3
+    }
+  }
+
   rule {
     id = "Expire non-current versions after 7 days"