fix: prevent filename completion of flags that don't take filename args (#366)

scop · web-flow · commit 0211273ace35 · 2025-02-04T12:45:36.000+02:00
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -16,6 +16,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 - List cloud native plans in their own section in human readable `server plans` output.
 
+### Fixed
+
+- Prevent filename completion of flags that don't take filename args.
+
 ## [3.14.0] - 2025-01-08
 
 ### Added
diff --git a/internal/commands/command.go b/internal/commands/command.go
@@ -141,6 +141,9 @@ func (s *BaseCommand) AddFlags(flags *pflag.FlagSet) {
 
 	flags.VisitAll(func(flag *pflag.Flag) {
 		s.Cobra().Flags().AddFlag(flag)
+		if _, ok := flag.Annotations[FlagAnnotationNoFileCompletions]; ok {
+			Must(s.Cobra().RegisterFlagCompletionFunc(flag.Name, cobra.NoFileCompletions))
+		}
 	})
 }
 
diff --git a/internal/commands/database/index/delete.go b/internal/commands/database/index/delete.go
@@ -9,6 +9,7 @@ import (
 	"github.com/UpCloudLtd/upcloud-cli/v3/internal/resolver"
 
 	"github.com/UpCloudLtd/upcloud-go-api/v8/upcloud/request"
+	"github.com/spf13/cobra"
 	"github.com/spf13/pflag"
 )
 
@@ -37,6 +38,7 @@ func (s *deleteCommand) InitCommand() {
 	s.AddFlags(flagSet)
 
 	commands.Must(s.Cobra().MarkFlagRequired("name"))
+	commands.Must(s.Cobra().RegisterFlagCompletionFunc("name", cobra.NoFileCompletions))
 }
 
 // Execute implements commands.MultipleArgumentCommand
diff --git a/internal/commands/database/session/cancel.go b/internal/commands/database/session/cancel.go
@@ -42,6 +42,7 @@ func (s *cancelCommand) InitCommand() {
 
 	s.AddFlags(flagSet)
 	commands.Must(s.Cobra().MarkFlagRequired("pid"))
+	commands.Must(flagSet.SetAnnotation("pid", commands.FlagAnnotationNoFileCompletions, nil))
 }
 
 // Execute implements commands.MultipleArgumentCommand
diff --git a/internal/commands/database/session/list.go b/internal/commands/database/session/list.go
@@ -12,6 +12,7 @@ import (
 
 	"github.com/UpCloudLtd/upcloud-go-api/v8/upcloud"
 	"github.com/UpCloudLtd/upcloud-go-api/v8/upcloud/request"
+	"github.com/spf13/cobra"
 	"github.com/spf13/pflag"
 )
 
@@ -44,6 +45,9 @@ func (s *listCommand) InitCommand() {
 	flagSet.StringVar(&s.order, "order", "query_duration:desc", "Key and direction for sorting.")
 
 	s.AddFlags(flagSet)
+	commands.Must(s.Cobra().RegisterFlagCompletionFunc("limit", cobra.NoFileCompletions))
+	commands.Must(s.Cobra().RegisterFlagCompletionFunc("offset", cobra.NoFileCompletions))
+	commands.Must(s.Cobra().RegisterFlagCompletionFunc("order", cobra.NoFileCompletions))
 }
 
 // Execute implements commands.MultipleArgumentCommand
diff --git a/internal/commands/ipaddress/assign.go b/internal/commands/ipaddress/assign.go
@@ -12,6 +12,7 @@ import (
 
 	"github.com/UpCloudLtd/upcloud-go-api/v8/upcloud"
 	"github.com/UpCloudLtd/upcloud-go-api/v8/upcloud/request"
+	"github.com/spf13/cobra"
 	"github.com/spf13/pflag"
 )
 
@@ -53,7 +54,9 @@ func (s *assignCommand) InitCommand() {
 	fs.StringVar(&s.mac, "mac", "", "MAC address of server interface to assign address to. Required for detached floating IP address if zone is not specified.")
 	fs.StringVar(&s.zone, "zone", "", (namedargs.ZoneDescription("IP address") + " Required when creating a detached floating IP address, i.e. when MAC address is not specified."))
 	config.AddToggleFlag(fs, &s.floating, "floating", false, "Whether the address to be assigned is a floating one.")
+
 	s.AddFlags(fs)
+	commands.Must(s.Cobra().RegisterFlagCompletionFunc("mac", cobra.NoFileCompletions))
 }
 
 func (s *assignCommand) InitCommandWithConfig(cfg *config.Config) {
diff --git a/internal/commands/kubernetes/create.go b/internal/commands/kubernetes/create.go
@@ -14,6 +14,7 @@ import (
 
 	"github.com/UpCloudLtd/upcloud-go-api/v8/upcloud"
 	"github.com/UpCloudLtd/upcloud-go-api/v8/upcloud/request"
+	"github.com/spf13/cobra"
 	"github.com/spf13/pflag"
 )
 
@@ -150,6 +151,7 @@ func (c *createCommand) InitCommand() {
 	commands.Must(c.Cobra().MarkFlagRequired("name"))
 	commands.Must(c.Cobra().MarkFlagRequired("network"))
 	commands.Must(c.Cobra().MarkFlagRequired("zone"))
+	commands.Must(c.Cobra().RegisterFlagCompletionFunc("name", cobra.NoFileCompletions))
 }
 
 func (c *createCommand) InitCommandWithConfig(cfg *config.Config) {
diff --git a/internal/commands/kubernetes/modify.go b/internal/commands/kubernetes/modify.go
@@ -12,6 +12,7 @@ import (
 
 	"github.com/UpCloudLtd/upcloud-go-api/v8/upcloud"
 	"github.com/UpCloudLtd/upcloud-go-api/v8/upcloud/request"
+	"github.com/spf13/cobra"
 	"github.com/spf13/pflag"
 )
 
@@ -50,6 +51,7 @@ func (c *modifyCommand) InitCommand() {
 
 	c.AddFlags(fs)
 	c.Cobra().MarkFlagsMutuallyExclusive("label", "clear-labels")
+	commands.Must(c.Cobra().RegisterFlagCompletionFunc("label", cobra.NoFileCompletions))
 }
 
 // Execute implements commands.MultipleArgumentCommand
diff --git a/internal/commands/kubernetes/nodegroup/create.go b/internal/commands/kubernetes/nodegroup/create.go
@@ -42,6 +42,14 @@ func GetCreateNodeGroupFlagSet(p *CreateNodeGroupParams) *pflag.FlagSet {
 	fs.StringArrayVar(&p.Taints, "taint", []string{}, "Taints to be configured to the nodes in `key=value:effect` format")
 	config.AddEnableOrDisableFlag(fs, &p.UtilityNetworkAccess, true, "utility-network-access", "utility network access. If disabled, nodes in this group will not have access to utility network")
 
+	commands.Must(fs.SetAnnotation("count", commands.FlagAnnotationNoFileCompletions, nil))
+	commands.Must(fs.SetAnnotation("kubelet-arg", commands.FlagAnnotationNoFileCompletions, nil))
+	commands.Must(fs.SetAnnotation("label", commands.FlagAnnotationNoFileCompletions, nil))
+	commands.Must(fs.SetAnnotation("name", commands.FlagAnnotationNoFileCompletions, nil))
+	commands.Must(fs.SetAnnotation("plan", commands.FlagAnnotationNoFileCompletions, nil))
+	commands.Must(fs.SetAnnotation("storage", commands.FlagAnnotationNoFileCompletions, nil))
+	commands.Must(fs.SetAnnotation("taint", commands.FlagAnnotationNoFileCompletions, nil))
+
 	return fs
 }
 
diff --git a/internal/commands/kubernetes/nodegroup/delete.go b/internal/commands/kubernetes/nodegroup/delete.go
@@ -8,6 +8,7 @@ import (
 	"github.com/UpCloudLtd/upcloud-cli/v3/internal/output"
 	"github.com/UpCloudLtd/upcloud-cli/v3/internal/resolver"
 	"github.com/UpCloudLtd/upcloud-go-api/v8/upcloud/request"
+	"github.com/spf13/cobra"
 	"github.com/spf13/pflag"
 )
 
@@ -36,6 +37,7 @@ func (s *deleteCommand) InitCommand() {
 	s.AddFlags(flagSet)
 
 	commands.Must(s.Cobra().MarkFlagRequired("name"))
+	commands.Must(s.Cobra().RegisterFlagCompletionFunc("name", cobra.NoFileCompletions))
 }
 
 // ExecuteSingleArgument implements commands.SingleArgumentCommand
diff --git a/internal/commands/kubernetes/nodegroup/scale.go b/internal/commands/kubernetes/nodegroup/scale.go
@@ -8,6 +8,7 @@ import (
 	"github.com/UpCloudLtd/upcloud-cli/v3/internal/output"
 	"github.com/UpCloudLtd/upcloud-cli/v3/internal/resolver"
 	"github.com/UpCloudLtd/upcloud-go-api/v8/upcloud/request"
+	"github.com/spf13/cobra"
 	"github.com/spf13/pflag"
 )
 
@@ -39,6 +40,8 @@ func (s *scaleCommand) InitCommand() {
 
 	commands.Must(s.Cobra().MarkFlagRequired("name"))
 	commands.Must(s.Cobra().MarkFlagRequired("count"))
+	commands.Must(s.Cobra().RegisterFlagCompletionFunc("name", cobra.NoFileCompletions))
+	commands.Must(s.Cobra().RegisterFlagCompletionFunc("count", cobra.NoFileCompletions))
 }
 
 // ExecuteSingleArgument implements commands.SingleArgumentCommand
diff --git a/internal/commands/kubernetes/nodegroup/show.go b/internal/commands/kubernetes/nodegroup/show.go
@@ -8,6 +8,7 @@ import (
 	"github.com/UpCloudLtd/upcloud-cli/v3/internal/output"
 	"github.com/UpCloudLtd/upcloud-cli/v3/internal/resolver"
 	"github.com/UpCloudLtd/upcloud-cli/v3/internal/ui"
+	"github.com/spf13/cobra"
 	"github.com/spf13/pflag"
 
 	"github.com/UpCloudLtd/upcloud-go-api/v8/upcloud/request"
@@ -38,6 +39,7 @@ func (s *showCommand) InitCommand() {
 	s.AddFlags(flagSet)
 
 	commands.Must(s.Cobra().MarkFlagRequired("name"))
+	commands.Must(s.Cobra().RegisterFlagCompletionFunc("name", cobra.NoFileCompletions))
 }
 
 // ExecuteSingleArgument implements commands.SingleArgumentCommand
diff --git a/internal/commands/network/network.go b/internal/commands/network/network.go
@@ -54,6 +54,8 @@ func handleNetwork(in string) (*upcloud.IPNetwork, error) {
 		return nil, err
 	}
 
+	commands.Must(fs.SetAnnotation("address", commands.FlagAnnotationNoFileCompletions, nil))
+
 	if dhcp != "" {
 		val, err := commands.BoolFromString(dhcp)
 		if err != nil {
diff --git a/internal/commands/partner/account/create.go b/internal/commands/partner/account/create.go
@@ -6,6 +6,7 @@ import (
 	"github.com/UpCloudLtd/upcloud-cli/v3/internal/commands"
 	"github.com/UpCloudLtd/upcloud-cli/v3/internal/output"
 	"github.com/UpCloudLtd/upcloud-go-api/v8/upcloud/request"
+	"github.com/spf13/cobra"
 	"github.com/spf13/pflag"
 )
 
@@ -47,6 +48,19 @@ func (s *createCommand) InitCommand() {
 	s.AddFlags(fs)
 	commands.Must(s.Cobra().MarkFlagRequired("username"))
 	commands.Must(s.Cobra().MarkFlagRequired("password"))
+	commands.Must(s.Cobra().RegisterFlagCompletionFunc("username", cobra.NoFileCompletions))
+	commands.Must(s.Cobra().RegisterFlagCompletionFunc("password", cobra.NoFileCompletions))
+	commands.Must(s.Cobra().RegisterFlagCompletionFunc("first-name", cobra.NoFileCompletions))
+	commands.Must(s.Cobra().RegisterFlagCompletionFunc("last-name", cobra.NoFileCompletions))
+	commands.Must(s.Cobra().RegisterFlagCompletionFunc("company", cobra.NoFileCompletions))
+	commands.Must(s.Cobra().RegisterFlagCompletionFunc("address", cobra.NoFileCompletions))
+	commands.Must(s.Cobra().RegisterFlagCompletionFunc("postal-code", cobra.NoFileCompletions))
+	commands.Must(s.Cobra().RegisterFlagCompletionFunc("city", cobra.NoFileCompletions))
+	commands.Must(s.Cobra().RegisterFlagCompletionFunc("state", cobra.NoFileCompletions))
+	commands.Must(s.Cobra().RegisterFlagCompletionFunc("country", cobra.NoFileCompletions))
+	commands.Must(s.Cobra().RegisterFlagCompletionFunc("phone", cobra.NoFileCompletions))
+	commands.Must(s.Cobra().RegisterFlagCompletionFunc("email", cobra.NoFileCompletions))
+	commands.Must(s.Cobra().RegisterFlagCompletionFunc("vat-number", cobra.NoFileCompletions))
 }
 
 func (s *createCommand) ExecuteWithoutArguments(exec commands.Executor) (output.Output, error) {
diff --git a/internal/commands/router/create.go b/internal/commands/router/create.go
@@ -7,6 +7,7 @@ import (
 	"github.com/UpCloudLtd/upcloud-cli/v3/internal/output"
 	"github.com/UpCloudLtd/upcloud-cli/v3/internal/ui"
 	"github.com/UpCloudLtd/upcloud-go-api/v8/upcloud/request"
+	"github.com/spf13/cobra"
 	"github.com/spf13/pflag"
 )
 
@@ -34,6 +35,7 @@ func (s *createCommand) InitCommand() {
 
 	s.AddFlags(fs)
 	commands.Must(s.Cobra().MarkFlagRequired("name"))
+	commands.Must(s.Cobra().RegisterFlagCompletionFunc("name", cobra.NoFileCompletions))
 }
 
 // MaximumExecutions implements Command.MaximumExecutions
diff --git a/internal/commands/router/modify.go b/internal/commands/router/modify.go
@@ -8,6 +8,7 @@ import (
 	"github.com/UpCloudLtd/upcloud-cli/v3/internal/output"
 	"github.com/UpCloudLtd/upcloud-cli/v3/internal/resolver"
 	"github.com/UpCloudLtd/upcloud-go-api/v8/upcloud/request"
+	"github.com/spf13/cobra"
 	"github.com/spf13/pflag"
 )
 
@@ -37,6 +38,7 @@ func (s *modifyCommand) InitCommand() {
 
 	s.AddFlags(fs)
 	commands.Must(s.Cobra().MarkFlagRequired("name"))
+	commands.Must(s.Cobra().RegisterFlagCompletionFunc("name", cobra.NoFileCompletions))
 }
 
 // ExecuteSingleArgument implements commands.SingleArgumentCommand
diff --git a/internal/commands/server/networkinterface/delete.go b/internal/commands/server/networkinterface/delete.go
@@ -8,6 +8,7 @@ import (
 	"github.com/UpCloudLtd/upcloud-cli/v3/internal/output"
 	"github.com/UpCloudLtd/upcloud-cli/v3/internal/resolver"
 	"github.com/UpCloudLtd/upcloud-go-api/v8/upcloud/request"
+	"github.com/spf13/cobra"
 	"github.com/spf13/pflag"
 )
 
@@ -37,6 +38,7 @@ func (s *deleteCommand) InitCommand() {
 
 	s.AddFlags(fs)
 	commands.Must(s.Cobra().MarkFlagRequired("index"))
+	commands.Must(s.Cobra().RegisterFlagCompletionFunc("index", cobra.NoFileCompletions))
 }
 
 // MaximumExecutions implements Command.MaximumExecutions
diff --git a/internal/commands/servergroup/create.go b/internal/commands/servergroup/create.go
@@ -13,6 +13,7 @@ import (
 
 	"github.com/UpCloudLtd/upcloud-go-api/v8/upcloud"
 	"github.com/UpCloudLtd/upcloud-go-api/v8/upcloud/request"
+	"github.com/spf13/cobra"
 	"github.com/spf13/pflag"
 )
 
@@ -94,6 +95,8 @@ func (c *createCommand) InitCommand() {
 	c.AddFlags(fs)
 
 	commands.Must(c.Cobra().MarkFlagRequired("title"))
+	commands.Must(c.Cobra().RegisterFlagCompletionFunc("title", cobra.NoFileCompletions))
+	commands.Must(c.Cobra().RegisterFlagCompletionFunc("label", cobra.NoFileCompletions))
 }
 
 func (c *createCommand) InitCommandWithConfig(cfg *config.Config) {
diff --git a/internal/commands/servergroup/modify.go b/internal/commands/servergroup/modify.go
@@ -13,6 +13,7 @@ import (
 	"github.com/UpCloudLtd/upcloud-go-api/v8/upcloud/request"
 
 	"github.com/UpCloudLtd/upcloud-go-api/v8/upcloud"
+	"github.com/spf13/cobra"
 	"github.com/spf13/pflag"
 )
 
@@ -86,6 +87,8 @@ func (c *modifyCommand) InitCommand() {
 	fs.StringArrayVar(&c.params.servers, "server", defaultModifyParams.servers, "Servers that belong to the server group, multiple can be declared. If set, all the existing server entries will be replaced with provided ones.\nUsage: --server my-server\n\n--server 00333d1b-3a4a-4b75-820a-4a56d70395dd")
 
 	c.AddFlags(fs)
+	commands.Must(c.Cobra().RegisterFlagCompletionFunc("title", cobra.NoFileCompletions))
+	commands.Must(c.Cobra().RegisterFlagCompletionFunc("label", cobra.NoFileCompletions))
 }
 
 func (c *modifyCommand) InitCommandWithConfig(cfg *config.Config) {
diff --git a/internal/commands/util.go b/internal/commands/util.go
@@ -16,6 +16,11 @@ import (
 	"golang.org/x/crypto/ssh"
 )
 
+const (
+	// FlagAnnotationNoFileCompletions is the annotation name to use for our flags that have no filename completions.
+	FlagAnnotationNoFileCompletions = "upctl_flag_no_file_completions"
+)
+
 // ParseN parses a complex, querystring-type argument from `in` and splits values to `n` amount of substrings
 // e.g. with `n` 2: `--foo bar=baz,flop=flip=1` returns `[]string{"bar","baz","flop","flip=1"}`
 func ParseN(in string, n int) ([]string, error) {
diff --git a/internal/core/core.go b/internal/core/core.go
@@ -116,6 +116,8 @@ func BuildRootCmd(conf *config.Config) cobra.Command {
 	rootCmd.SetUsageTemplate(ui.CommandUsageTemplate())
 	rootCmd.SetUsageFunc(ui.UsageFunc)
 
+	commands.Must(rootCmd.RegisterFlagCompletionFunc("client-timeout", cobra.NoFileCompletions))
+
 	return rootCmd
 }
 
diff --git a/internal/paging/paging.go b/internal/paging/paging.go
@@ -1,6 +1,7 @@
 package paging
 
 import (
+	"github.com/UpCloudLtd/upcloud-cli/v3/internal/commands"
 	"github.com/UpCloudLtd/upcloud-go-api/v8/upcloud/request"
 	"github.com/spf13/pflag"
 )
@@ -13,6 +14,9 @@ type PageParameters struct {
 func (pp *PageParameters) ConfigureFlags(fs *pflag.FlagSet) {
 	fs.IntVar(&pp.size, "limit", 100, "Number of entries to receive at most.")
 	fs.IntVar(&pp.number, "page", 0, "Page number to calculate first item to receive. Page numbers start from `1`.")
+
+	commands.Must(fs.SetAnnotation("limit", commands.FlagAnnotationNoFileCompletions, nil))
+	commands.Must(fs.SetAnnotation("page", commands.FlagAnnotationNoFileCompletions, nil))
 }
 
 func (pp *PageParameters) Page() *request.Page {

Original file line number	Diff line number	Diff line change
`@@ -141,6 +141,9 @@ func (s BaseCommand) AddFlags(flags pflag.FlagSet) {`
`141`	`141`
`142`	`142`	`flags.VisitAll(func(flag *pflag.Flag) {`
`143`	`143`	`s.Cobra().Flags().AddFlag(flag)`
	`144`	`+ if _, ok := flag.Annotations[FlagAnnotationNoFileCompletions]; ok {`
	`145`	`+ Must(s.Cobra().RegisterFlagCompletionFunc(flag.Name, cobra.NoFileCompletions))`
	`146`	`+ }`
`144`	`147`	`})`
`145`	`148`	`}`
`146`	`149`
Original file line number	Diff line number	Diff line change
`@@ -9,6 +9,7 @@ import (`
`9`	`9`	`"github.com/UpCloudLtd/upcloud-cli/v3/internal/resolver"`
`10`	`10`
`11`	`11`	`"github.com/UpCloudLtd/upcloud-go-api/v8/upcloud/request"`
	`12`	`+ "github.com/spf13/cobra"`
`12`	`13`	`"github.com/spf13/pflag"`
`13`	`14`	`)`
`14`	`15`
`@@ -37,6 +38,7 @@ func (s *deleteCommand) InitCommand() {`
`37`	`38`	`s.AddFlags(flagSet)`
`38`	`39`
`39`	`40`	`commands.Must(s.Cobra().MarkFlagRequired("name"))`
	`41`	`+ commands.Must(s.Cobra().RegisterFlagCompletionFunc("name", cobra.NoFileCompletions))`
`40`	`42`	`}`
`41`	`43`
`42`	`44`	`// Execute implements commands.MultipleArgumentCommand`
Original file line number	Diff line number	Diff line change
`@@ -42,6 +42,7 @@ func (s *cancelCommand) InitCommand() {`
`42`	`42`
`43`	`43`	`s.AddFlags(flagSet)`
`44`	`44`	`commands.Must(s.Cobra().MarkFlagRequired("pid"))`
	`45`	`+ commands.Must(flagSet.SetAnnotation("pid", commands.FlagAnnotationNoFileCompletions, nil))`
`45`	`46`	`}`
`46`	`47`
`47`	`48`	`// Execute implements commands.MultipleArgumentCommand`
Original file line number	Diff line number	Diff line change
`@@ -12,6 +12,7 @@ import (`
`12`	`12`
`13`	`13`	`"github.com/UpCloudLtd/upcloud-go-api/v8/upcloud"`
`14`	`14`	`"github.com/UpCloudLtd/upcloud-go-api/v8/upcloud/request"`
	`15`	`+ "github.com/spf13/cobra"`
`15`	`16`	`"github.com/spf13/pflag"`
`16`	`17`	`)`
`17`	`18`
`@@ -44,6 +45,9 @@ func (s *listCommand) InitCommand() {`
`44`	`45`	`flagSet.StringVar(&s.order, "order", "query_duration:desc", "Key and direction for sorting.")`
`45`	`46`
`46`	`47`	`s.AddFlags(flagSet)`
	`48`	`+ commands.Must(s.Cobra().RegisterFlagCompletionFunc("limit", cobra.NoFileCompletions))`
	`49`	`+ commands.Must(s.Cobra().RegisterFlagCompletionFunc("offset", cobra.NoFileCompletions))`
	`50`	`+ commands.Must(s.Cobra().RegisterFlagCompletionFunc("order", cobra.NoFileCompletions))`
`47`	`51`	`}`
`48`	`52`
`49`	`53`	`// Execute implements commands.MultipleArgumentCommand`
Original file line number	Diff line number	Diff line change
`@@ -14,6 +14,7 @@ import (`
`14`	`14`
`15`	`15`	`"github.com/UpCloudLtd/upcloud-go-api/v8/upcloud"`
`16`	`16`	`"github.com/UpCloudLtd/upcloud-go-api/v8/upcloud/request"`
	`17`	`+ "github.com/spf13/cobra"`
`17`	`18`	`"github.com/spf13/pflag"`
`18`	`19`	`)`
`19`	`20`
`@@ -150,6 +151,7 @@ func (c *createCommand) InitCommand() {`
`150`	`151`	`commands.Must(c.Cobra().MarkFlagRequired("name"))`
`151`	`152`	`commands.Must(c.Cobra().MarkFlagRequired("network"))`
`152`	`153`	`commands.Must(c.Cobra().MarkFlagRequired("zone"))`
	`154`	`+ commands.Must(c.Cobra().RegisterFlagCompletionFunc("name", cobra.NoFileCompletions))`
`153`	`155`	`}`
`154`	`156`
`155`	`157`	`func (c createCommand) InitCommandWithConfig(cfg config.Config) {`
Original file line number	Diff line number	Diff line change
`@@ -8,6 +8,7 @@ import (`
`8`	`8`	`"github.com/UpCloudLtd/upcloud-cli/v3/internal/output"`
`9`	`9`	`"github.com/UpCloudLtd/upcloud-cli/v3/internal/resolver"`
`10`	`10`	`"github.com/UpCloudLtd/upcloud-go-api/v8/upcloud/request"`
	`11`	`+ "github.com/spf13/cobra"`
`11`	`12`	`"github.com/spf13/pflag"`
`12`	`13`	`)`
`13`	`14`
`@@ -36,6 +37,7 @@ func (s *deleteCommand) InitCommand() {`
`36`	`37`	`s.AddFlags(flagSet)`
`37`	`38`
`38`	`39`	`commands.Must(s.Cobra().MarkFlagRequired("name"))`
	`40`	`+ commands.Must(s.Cobra().RegisterFlagCompletionFunc("name", cobra.NoFileCompletions))`
`39`	`41`	`}`
`40`	`42`
`41`	`43`	`// ExecuteSingleArgument implements commands.SingleArgumentCommand`