chore(deps): bump golangci/golangci-lint-action from 4.0.0 to 8.0.0 (#441)

Author: dependabot[bot]

.github/workflows/lint.yml

@@ -20,6 +20,6 @@ jobs:
         with:
           go-version-file: 'go.mod'
       - name: Run golangci-lint-action
-        uses: golangci/golangci-lint-action@3cfe3a4abbb849e10058ce4af15d205b6da42804 # v4.0.0
+        uses: golangci/golangci-lint-action@4afd733a84b1f43292c63897423277bb7f4313a9 # v8.0.0
         with:
           args: --timeout=2m

.golangci.yaml

@@ -1,9 +1,6 @@
-# Golang CI pipeline configuration
+version: "2"
 linters:
-  disable-all: true
-
-  # Run golangci-lint linters to see the list of all linters
-  # Please keep them sorted alphabetically
+  default: none
   enable:
     - asasalint
     - asciicheck
@@ -14,12 +11,9 @@ linters:
     - errcheck
     - goconst
     - gocritic
-    - gofumpt
-    - goimports
     - gomoddirectives
     - goprintffuncname
     - gosec
-    - gosimple
     - govet
     - ineffassign
     - makezero
@@ -32,24 +26,47 @@ linters:
     - revive
     - rowserrcheck
     - staticcheck
-    - stylecheck
-    - tenv
-    - typecheck
     - unconvert
     - unused
     - wastedassign
     - whitespace
-
+  settings:
+    goconst:
+      min-len: 5
+    revive:
+      rules:
+        - name: var-naming
+          arguments:
+          - []
+          - []
+          - - skip-package-name-checks: true
+  exclusions:
+    generated: lax
+    presets:
+      - comments
+      - common-false-positives
+      - legacy
+      - std-error-handling
+    rules:
+      - linters:
+          - bodyclose
+          - funlen
+        path: _test\.go
+    paths:
+      - third_party$
+      - builtin$
+      - examples$
 issues:
   max-issues-per-linter: 0
   max-same-issues: 0
   uniq-by-line: false
-  exclude-rules:
-    - path: _test\.go
-      linters:
-        - funlen
-        - bodyclose
-
-linters-settings:
-  goconst:
-    min-len: 5
+formatters:
+  enable:
+    - gofumpt
+    - goimports
+  exclusions:
+    generated: lax
+    paths:
+      - third_party$
+      - builtin$
+      - examples$

internal/commands/gateway/list.go

@@ -27,7 +27,7 @@ type listCommand struct {
 
 func (c *listCommand) InitCommand() {
 	fs := &pflag.FlagSet{}
-	c.PageParameters.ConfigureFlags(fs)
+	c.ConfigureFlags(fs)
 	c.AddFlags(fs)
 }
 

internal/commands/network/show.go

@@ -39,7 +39,7 @@ func (s *showCommand) InitCommand() {
 
 // Execute implements commands.MultipleArgumentCommand
 func (s *showCommand) Execute(exec commands.Executor, arg string) (output.Output, error) {
-	network, err := s.CachingNetwork.GetCached(arg)
+	network, err := s.GetCached(arg)
 	if err != nil {
 		return nil, err
 	}

internal/commands/router/show.go

@@ -37,7 +37,7 @@ func (s *showCommand) InitCommand() {
 
 // Execute implements commands.MultipleArgumentCommand
 func (s *showCommand) Execute(exec commands.Executor, arg string) (output.Output, error) {
-	router, err := s.CachingRouter.GetCached(arg)
+	router, err := s.GetCached(arg)
 	if err != nil {
 		return nil, err
 	}

internal/commands/server/create.go

@@ -98,7 +98,7 @@ func (s *createParams) processParams(exec commands.Executor) error {
 
 		// Enable metadata service for cloud-init templates. Leave empty for other templates to use value defined by user.
 		if osStorage.TemplateType == upcloud.StorageTemplateTypeCloudInit {
-			s.CreateServerRequest.Metadata = upcloud.True
+			s.Metadata = upcloud.True
 		}
 
 		s.StorageDevices = append(s.StorageDevices, request.CreateServerStorageDevice{

internal/commands/server/server.go

@@ -24,7 +24,7 @@ const (
 	simpleBackupDescription = "Simple backup rule in `HHMM,{daily,dailies,weeklies,monthlies}` format or `no`. For example: `2300,dailies`."
 )
 
-// BaseServerCommand crestes the base "server" command
+// BaseServerCommand creates the base "server" command
 func BaseServerCommand() commands.Command {
 	return &serverCommand{
 		commands.New("server", "Manage servers"),

internal/commands/zone/devices/devices.go

@@ -7,7 +7,7 @@ import (
 )
 
 // DevicesCommand creates the "zone devices" command
-func DevicesCommand() commands.Command { //nolint:revive // Does not make sense to add Base prefix here to avoid stuttering warning
+func DevicesCommand() commands.Command {
 	return &devicesCommand{
 		BaseCommand: commands.New("devices", "List available devices for each zone", "upctl zone devices"),
 	}

internal/mock/mock.go

@@ -1,4 +1,4 @@
-//nolint:nilnil,revive // Here nil, nil returns and unused parameters are used in not-implemented methods required to satisfy an interface and it does not make sense to rename them when copying functions from our SDK
+//nolint:nilnil // Here nil, nil returns and unused parameters are used in not-implemented methods required to satisfy an interface and it does not make sense to rename them when copying functions from our SDK
 package mock
 
 import (

internal/resolver/kubernetes.go

@@ -43,5 +43,5 @@ func (s *CachingKubernetes) Get(ctx context.Context, svc service.AllServices) (R
 
 // PositionalArgumentHelp implements resolver.ResolutionProvider
 func (s CachingKubernetes) PositionalArgumentHelp() string {
-	return "<UUID/Name...>" //nolint:goconst
+	return helpUUIDName
 }