Skip to content

Commit 41d1227

Browse files
committed
fix(resolver): clarify error messages relating to argument resolution
1 parent 0a5ff5b commit 41d1227

2 files changed

Lines changed: 4 additions & 2 deletions

File tree

CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,8 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
66
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
77

88
## [Unreleased]
9+
### Fixed
10+
- Improved errors relating to argument resolver failures
911

1012
## [1.1.3] - 2022-02-24
1113
### Changed

internal/commands/runcommand.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ func resolveArguments(nc Command, svc internal.AllServices, args []string) (out
8585
if resolve, ok := nc.(resolver.ResolutionProvider); ok {
8686
argumentResolver, err := resolve.Get(svc)
8787
if err != nil {
88-
return nil, fmt.Errorf("cannot create resolver: %w", err)
88+
return nil, fmt.Errorf("cannot get resolver: %w", err)
8989
}
9090
for _, arg := range args {
9191
resolved, err := argumentResolver(arg)
@@ -102,7 +102,7 @@ func resolveArguments(nc Command, svc internal.AllServices, args []string) (out
102102
func execute(command Command, executor Executor, args []string, parallelRuns int, executeCommand func(exec Executor, arg string) (output.Output, error)) ([]executeResult, error) {
103103
resolvedArgs, err := resolveArguments(command, executor.All(), args)
104104
if err != nil {
105-
return nil, fmt.Errorf("cannot create resolver: %w", err)
105+
return nil, fmt.Errorf("cannot resolve command line arguments: %w", err)
106106
}
107107

108108
returnChan := make(chan executeResult)

0 commit comments

Comments
 (0)