chore: enable more linters

Author: kangasta

.golangci.yaml

@@ -12,24 +12,30 @@ linters:
     - errcheck
     - goconst
     - gocritic
+    # TODO "upgrade" to gofumpt
     - gofmt
     - goimports
     - goprintffuncname
-#    - gosec
+    - gosec
     - gosimple
     - govet
     - ineffassign
+    - makezero
     - misspell
     - nakedret
+    - nilnil
     - nolintlint
+    - nosprintfhostport
+    - predeclared
     - revive
     - rowserrcheck
     - staticcheck
     - structcheck
     - stylecheck
+    - tenv
     - typecheck
     - unconvert
-#    - unparam
+    - unused
     - varcheck
     - whitespace
 
@@ -39,4 +45,4 @@ linters-settings:
       # TODO: re-enable after figuring out why runcommand fails on go-critic..
       - unlambda
   goconst:
-    min-len: 5
+    min-len: 5

go.mod

@@ -7,7 +7,6 @@ require (
 	github.com/adrg/xdg v0.3.2
 	github.com/asaskevich/govalidator v0.0.0-20210307081110-f21760c49a8d
 	github.com/gemalto/flume v0.12.0
-	github.com/hashicorp/go-cleanhttp v0.5.1
 	github.com/jedib0t/go-pretty/v6 v6.0.5
 	github.com/m7shapan/cidr v0.0.0-20200427124835-7eba0889a5d2
 	github.com/mattn/go-isatty v0.0.12
@@ -26,6 +25,7 @@ require (
 	github.com/cpuguy83/go-md2man/v2 v2.0.2 // indirect
 	github.com/davecgh/go-spew v1.1.1 // indirect
 	github.com/fsnotify/fsnotify v1.4.9 // indirect
+	github.com/hashicorp/go-cleanhttp v0.5.1 // indirect
 	github.com/hashicorp/hcl v1.0.0 // indirect
 	github.com/inconshreveable/mousetrap v1.0.0 // indirect
 	github.com/kr/text v0.2.0 // indirect

internal/config/config.go

@@ -2,7 +2,6 @@ package config
 
 import (
 	"fmt"
-	"net/http"
 	"path/filepath"
 	"strings"
 	"time"
@@ -13,7 +12,6 @@ import (
 	"github.com/UpCloudLtd/upcloud-go-api/v4/upcloud/service"
 	"github.com/adrg/xdg"
 	"github.com/gemalto/flume"
-	"github.com/hashicorp/go-cleanhttp"
 	"github.com/spf13/pflag"
 	"github.com/spf13/viper"
 )
@@ -173,13 +171,6 @@ func (s *Config) ClientTimeout() time.Duration {
 	return s.viper.GetDuration(KeyClientTimeout)
 }
 
-type transport struct{}
-
-// RoundTrip implements http.RoundTripper
-func (t *transport) RoundTrip(req *http.Request) (*http.Response, error) {
-	return cleanhttp.DefaultTransport().RoundTrip(req)
-}
-
 // CreateService creates a new service instance and puts in the conf struct
 func (s *Config) CreateService() (internal.AllServices, error) {
 	username := s.GetString("username")

internal/mock/mock.go

@@ -1,3 +1,4 @@
+//nolint:nilnil // Here nil, nil returns are used in not-implemented methods required to satisfy an interface
 package mock
 
 import (