refactor(client): use default SDK client (#96)

Signed-off-by: Amine Kherbouche <kaminek92@gmail.com>

Co-authored-by: Pekka Nurmi <pekka.nurmi@upcloud.com>

Author: kaminek

internal/config/config.go

@@ -196,20 +196,15 @@ func (s *Config) CreateService() (internal.AllServices, error) {
 		return nil, fmt.Errorf("user credentials not found, these must be set in config file (%s) or via environment variables", configDetails)
 	}
 
-	hc := &http.Client{Transport: &transport{}, Timeout: s.ClientTimeout()}
-	whc := client.NewWithHTTPClient(
-		username,
-		password,
-		hc,
-	)
+	client := client.New(username, password)
 	// TODO: remove this after go-api actually respects 0 timeout
 	// this is in order to enforce our custom (no) timeout because currently go-api
 	// assumes 0 timeout means 'not set' rather than 'no timeout'.
 	// see https://github.com/UpCloudLtd/upcloud-go-api/blob/2964ed7e597209b50a21f34259a20249e9aa220c/upcloud/client/client.go#L48
-	hc.Timeout = s.ClientTimeout()
+	client.SetTimeout(s.ClientTimeout())
+	client.UserAgent = fmt.Sprintf("upctl/%s", Version)
 
-	whc.UserAgent = fmt.Sprintf("upctl/%s", Version)
-	svc := service.New(whc)
+	svc := service.New(client)
 	// TODO; remove this when refactor is complete
 	s.Service = internal.Wrapper{Service: svc}
 	return svc, nil