fix(server): return error if trying to parse addresses from invalid type

kangasta · kangasta · commit 6959155e5780 · 2022-04-20T13:13:30.000+03:00
diff --git a/internal/commands/server/create.go b/internal/commands/server/create.go
@@ -378,7 +378,7 @@ func (s *createCommand) ExecuteWithoutArguments(exec commands.Executor) (output.
 func formatIPAddresses(val interface{}) (text.Colors, string, error) {
 	server, ok := val.(*upcloud.ServerDetails)
 	if !ok {
-		return nil, fmt.Sprint(val), nil
+		return nil, "", fmt.Errorf("cannot parse IP addresses from %T, expected *upcloud.ServerDetails", val)
 	}
 
 	// Store addresses in map keys to avoid duplicate addresses

Original file line number	Diff line number	Diff line change
`@@ -378,7 +378,7 @@ func (s *createCommand) ExecuteWithoutArguments(exec commands.Executor) (output.`
`378`	`378`	`func formatIPAddresses(val interface{}) (text.Colors, string, error) {`
`379`	`379`	`server, ok := val.(*upcloud.ServerDetails)`
`380`	`380`	`if !ok {`
`381`		`- return nil, fmt.Sprint(val), nil`
	`381`	`+ return nil, "", fmt.Errorf("cannot parse IP addresses from %T, expected *upcloud.ServerDetails", val)`
`382`	`382`	`}`
`383`	`383`
`384`	`384`	`// Store addresses in map keys to avoid duplicate addresses`