fix: use account currency when formatting credits (#666)

Author: ioannaragia

CHANGELOG.md

@@ -11,6 +11,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 - Log API requests and responses when using global `--debug` option.
 
+### Fixed
+
+- In human readable output of `account show`, use accounts currency for credits.
+
 ## [3.27.0] - 2025-12-31
 
 ### Added

internal/commands/account/show.go

@@ -6,6 +6,7 @@ import (
 
 	"github.com/UpCloudLtd/upcloud-cli/v3/internal/commands"
 	"github.com/UpCloudLtd/upcloud-cli/v3/internal/output"
+	"github.com/UpCloudLtd/upcloud-go-api/v8/upcloud/request"
 	"github.com/jedib0t/go-pretty/v6/text"
 )
 
@@ -28,14 +29,22 @@ func (s *showCommand) ExecuteWithoutArguments(exec commands.Executor) (output.Ou
 		return nil, err
 	}
 
+	detailsAccount, err := svc.GetAccountDetails(exec.Context(), &request.GetAccountDetailsRequest{Username: account.UserName})
+	if err != nil {
+		return nil, err
+	}
+
+	creditsFormatter := getFormatCredits(detailsAccount.Currency)
+
 	details := output.Details{
 		Sections: []output.DetailSection{
 			{
 				Rows: []output.DetailRow{
 					{Title: "Username:", Key: "username", Value: account.UserName},
-					{Title: "Credits:", Key: "credits", Value: account.Credits, Format: formatCredits},
+					{Title: "Credits:", Key: "credits", Value: account.Credits, Format: creditsFormatter},
 				},
 			},
+
 			{
 				Title: "Resource Limits:", Key: "resource_limits", Rows: []output.DetailRow{
 					{
@@ -119,16 +128,18 @@ func (s *showCommand) ExecuteWithoutArguments(exec commands.Executor) (output.Ou
 	}, nil
 }
 
-func formatCredits(val any) (text.Colors, string, error) {
-	credits, ok := val.(float64)
-	if !ok {
-		return nil, "", fmt.Errorf("cannot parse %T, expected float64", val)
-	}
+func getFormatCredits(currency string) func(val any) (text.Colors, string, error) {
+	return func(val any) (text.Colors, string, error) {
+		credits, ok := val.(float64)
+		if !ok {
+			return nil, "", fmt.Errorf("cannot parse %T, expected float64", val)
+		}
 
-	if math.Abs(credits) < 0.001 {
-		return nil, "Denied", nil
-	}
+		if math.Abs(credits) < 0.001 {
+			return nil, "Denied", nil
+		}
 
-	// Format does not follow european standards, but this is in sync with UI
-	return nil, fmt.Sprintf("€%.2f", credits/100), nil
+		// Credits are returned in cents
+		return nil, fmt.Sprintf("%.2f %s", credits/100, currency), nil
+	}
 }

internal/commands/account/show_test.go

@@ -12,6 +12,7 @@ import (
 
 	"github.com/UpCloudLtd/upcloud-go-api/v8/upcloud"
 	"github.com/stretchr/testify/assert"
+	"github.com/stretchr/testify/mock"
 )
 
 func TestShowCommand(t *testing.T) {
@@ -39,7 +40,7 @@ func TestShowCommand(t *testing.T) {
 
 	expected := `  
   Username: upctl_test 
-  Credits:  €123.45    
+  Credits:  123.45 EUR 
   
   Resource Limits:
     Cores:                      100 
@@ -64,6 +65,10 @@ func TestShowCommand(t *testing.T) {
 	mService := new(smock.Service)
 
 	mService.On("GetAccount").Return(&account, nil)
+	mService.On("GetAccountDetails", mock.Anything).Return(&upcloud.AccountDetails{
+		Currency: "EUR",
+	}, nil)
+
 	// force human output
 	conf.Viper().Set(config.KeyOutput, config.ValueOutputHuman)
 
@@ -73,4 +78,5 @@ func TestShowCommand(t *testing.T) {
 	assert.NoError(t, err)
 	assert.Equal(t, expected, output)
 	mService.AssertNumberOfCalls(t, "GetAccount", 1)
+	mService.AssertNumberOfCalls(t, "GetAccountDetails", 1)
 }