fix(livelog): render started/done pending entries on first livelog.Render call

The livelog is rendered only once if command execution takes less than render tick interval. Previously, pending log messages were moved to in progress state on first render and rendered on second render. This caused log messages to not be rendered.

Author: kangasta

CHANGELOG.md

@@ -17,6 +17,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - Print version info, instead of missing credentials error, when runnning `upctl version` without credentials
 - Disable colors when outputting in JSON or YAML format
 - Display both public and private addresses in `server create` output
+- Render livelog messages of commands which execution takes less than render tick interval
 
 ## [1.1.3] - 2022-02-24
 ### Changed

internal/ui/log.go

@@ -129,6 +129,20 @@ func (s *LiveLog) Render() {
 		s.eraseLine()                   // erase the end of line
 		s.write(text.CursorUp.Sprint()) // and move up
 	}
+
+	// Move pending entries that have started to in progress
+	newPending := s.entriesPending[:0]
+	for _, entry := range s.entriesPending {
+		isStarted := !entry.started.IsZero()
+		if !isStarted {
+			newPending = append(newPending, entry)
+			continue
+		}
+		s.entriesInProgress = append(s.entriesInProgress, entry)
+	}
+	s.entriesPending = newPending
+
+	// Move in progress entries that have completed to done
 	newInProgress := s.entriesInProgress[:0]
 	// Render any completed
 	for _, entry := range s.entriesInProgress {
@@ -147,18 +161,6 @@ func (s *LiveLog) Render() {
 	}
 	s.entriesInProgress = newInProgress
 
-	// Add any pending entries that have started
-	newPending := s.entriesPending[:0]
-	for _, entry := range s.entriesPending {
-		isStarted := !entry.started.IsZero()
-		if !isStarted {
-			newPending = append(newPending, entry)
-			continue
-		}
-		s.entriesInProgress = append(s.entriesInProgress, entry)
-	}
-	s.entriesPending = newPending
-
 	if s.config.DisableLiveRendering {
 		return
 	}

internal/ui/log_test.go

@@ -0,0 +1,30 @@
+package ui
+
+import (
+	"bytes"
+	"fmt"
+	"testing"
+
+	"github.com/stretchr/testify/assert"
+)
+
+// TestLogRender ensures that log entries are outputted with single Render call
+func TestLogRender(t *testing.T) {
+	var b bytes.Buffer
+	config := LiveLogDefaultConfig
+	config.EntryMaxWidth = 50
+	livelog := NewLiveLog(&b, config)
+
+	// Simulate typical livelog usage
+	msg := "Testing log.Render"
+	entry := NewLogEntry(msg)
+	livelog.AddEntries(entry)
+	entry.StartedNow()
+	entry.SetMessage(fmt.Sprintf("%s: Done", msg))
+	entry.MarkDone()
+	livelog.Render()
+	livelog.Close()
+
+	assert.Contains(t, b.String(), msg)
+	assert.Contains(t, b.String(), ": Done")
+}