chore: address golangci 2.7.0 and modernize findings (#614)

Big PR, but the bulk of it are modernize's `interface{}` to `any`
autofixes.

---------

Co-authored-by: Ville Välimäki <ville.valimaki@upcloud.com>

Author: scop

.golangci.yaml

@@ -18,6 +18,7 @@ linters:
     - ineffassign
     - makezero
     - misspell
+    - modernize
     - nakedret
     - nilnil
     - nolintlint

internal/commands/account/list.go

@@ -50,7 +50,7 @@ func (l *listCommand) ExecuteWithoutArguments(exec commands.Executor) (output.Ou
 	}, nil
 }
 
-func formatRoles(val interface{}) (text.Colors, string, error) {
+func formatRoles(val any) (text.Colors, string, error) {
 	roles, ok := val.([]string)
 	if !ok {
 		return nil, "", fmt.Errorf("cannot parse %T, expected []string", val)

internal/commands/account/permissions/list.go

@@ -74,7 +74,7 @@ func (l *listCommand) ExecuteWithoutArguments(exec commands.Executor) (output.Ou
 	}, nil
 }
 
-func formatOptions(val interface{}) (text.Colors, string, error) {
+func formatOptions(val any) (text.Colors, string, error) {
 	options, ok := val.(*upcloud.PermissionOptions)
 	if !ok {
 		return nil, "", fmt.Errorf("cannot parse %T, expected *upcloud.PermissionOptions", val)

internal/commands/account/show.go

@@ -119,7 +119,7 @@ func (s *showCommand) ExecuteWithoutArguments(exec commands.Executor) (output.Ou
 	}, nil
 }
 
-func formatCredits(val interface{}) (text.Colors, string, error) {
+func formatCredits(val any) (text.Colors, string, error) {
 	credits, ok := val.(float64)
 	if !ok {
 		return nil, "", fmt.Errorf("cannot parse %T, expected float64", val)

internal/commands/account/token/create_test.go

@@ -55,7 +55,7 @@ func TestCreateToken(t *testing.T) {
 			args: []string{
 				"--expires-in", "1h",
 			},
-			errFn: func(t assert.TestingT, err error, _ ...interface{}) bool {
+			errFn: func(t assert.TestingT, err error, _ ...any) bool {
 				return assert.ErrorContains(t, err, `required flag(s) "name" not set`)
 			},
 		},
@@ -65,7 +65,7 @@ func TestCreateToken(t *testing.T) {
 				"--name", "test",
 				"--expires-in", "seppo",
 			},
-			errFn: func(t assert.TestingT, err error, _ ...interface{}) bool {
+			errFn: func(t assert.TestingT, err error, _ ...any) bool {
 				return assert.ErrorContains(t, err, `invalid argument "seppo" for "--expires-in"`)
 			},
 		},
@@ -75,7 +75,7 @@ func TestCreateToken(t *testing.T) {
 				"--name", "test",
 				"--expires-at", "seppo",
 			},
-			errFn: func(t assert.TestingT, err error, _ ...interface{}) bool {
+			errFn: func(t assert.TestingT, err error, _ ...any) bool {
 				return assert.ErrorContains(t, err, `invalid expires-at: `)
 			},
 		},
@@ -84,7 +84,7 @@ func TestCreateToken(t *testing.T) {
 			args: []string{
 				"--name", "test",
 			},
-			errFn: func(t assert.TestingT, err error, _ ...interface{}) bool {
+			errFn: func(t assert.TestingT, err error, _ ...any) bool {
 				return assert.ErrorContains(t, err, `either expires-in or expires-at must be set`)
 			},
 		},

internal/commands/all/list.go

@@ -62,7 +62,7 @@ func (c *listCommand) ExecuteWithoutArguments(exec commands.Executor) (output.Ou
 	}, nil
 }
 
-func formatUUID(val interface{}) (text.Colors, string, error) {
+func formatUUID(val any) (text.Colors, string, error) {
 	str, ok := val.(string)
 	if !ok {
 		return nil, "", fmt.Errorf("cannot parse %T, expected string", val)

internal/commands/all/purge_test.go

@@ -17,12 +17,12 @@ func TestPurgeCommand(t *testing.T) {
 	for _, test := range []struct {
 		name   string
 		args   []string
-		called [][]interface{}
+		called [][]any
 	}{
 		{
 			name: "purge non-persistent tf-acc-test resources",
 			args: []string{"--include", "*tf-acc-test*", "--exclude", "*persistent*"},
-			called: [][]interface{}{
+			called: [][]any{
 				{"DeleteManagedObjectStorage", &request.DeleteManagedObjectStorageRequest{
 					UUID: objectStorages[0].UUID,
 				}},

internal/commands/all/resource.go

@@ -126,10 +126,7 @@ type findResult struct {
 }
 
 func findResources[T any](exec commands.Executor, wg *sync.WaitGroup, returnChan chan findResult, r resolver.CachingResolutionProvider[T], include, exclude []string) {
-	wg.Add(1)
-
-	go func() {
-		defer wg.Done()
+	wg.Go(func() {
 		var resources []Resource
 		matches, err := getMatches(exec, r, include, exclude)
 		if err != nil {
@@ -145,7 +142,7 @@ func findResources[T any](exec commands.Executor, wg *sync.WaitGroup, returnChan
 			resources = append(resources, resource)
 		}
 		returnChan <- findResult{Resources: resources, Error: nil}
-	}()
+	})
 }
 
 func ListResources(exec commands.Executor, include, exclude []string) ([]Resource, error) {
@@ -318,7 +315,7 @@ func DeleteResources(exec commands.Executor, resources []Resource, workerCount i
 	}
 
 	workerQueue := make(chan int, workerCount)
-	for n := 0; n < workerCount; n++ {
+	for n := range workerCount {
 		workerQueue <- n
 	}
 

internal/commands/command.go

@@ -3,6 +3,7 @@ package commands
 import (
 	"context"
 	"fmt"
+	"slices"
 	"strings"
 
 	"github.com/UpCloudLtd/upcloud-cli/v3/internal/completion"
@@ -161,12 +162,7 @@ func (s *BaseCommand) Aliases() []string {
 
 // isDeprecatedAlias checks if an alias is deprecated
 func (s *BaseCommand) isDeprecatedAlias(alias string) bool {
-	for _, deprecated := range s.deprecatedAliases {
-		if alias == deprecated {
-			return true
-		}
-	}
-	return false
+	return slices.Contains(s.deprecatedAliases, alias)
 }
 
 func (s *BaseCommand) DeprecatedAliases() []string {

internal/commands/database/create.go

@@ -133,7 +133,7 @@ func processProperties(in []string, t *upcloud.ManagedDatabaseType) (request.Man
 			continue
 		}
 
-		var parsedValue interface{}
+		var parsedValue any
 		if err := json.Unmarshal([]byte(value), &parsedValue); err != nil {
 			resp.Set(key, value) // Set as plain string if parsing fails
 		} else {
@@ -147,9 +147,9 @@ func processNetworks(in []string) ([]upcloud.ManagedDatabaseNetwork, error) {
 	var networks []upcloud.ManagedDatabaseNetwork
 	for _, netStr := range in {
 		network := upcloud.ManagedDatabaseNetwork{}
-		pairs := strings.Split(netStr, ",")
+		pairs := strings.SplitSeq(netStr, ",")
 
-		for _, pair := range pairs {
+		for pair := range pairs {
 			parts := strings.SplitN(pair, "=", 2)
 			if len(parts) != 2 {
 				return nil, fmt.Errorf("invalid network format: %s, expected key=value", pair)