fix(completions): convert key to lowercase if caseSensitive is false

Author: kangasta

CHANGELOG.md

@@ -7,7 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 ### Added
-- Add `--show-ip-addresses` flag to `server list` command to optionally include IP addresses in command output. 
+- Add `--show-ip-addresses` flag to `server list` command to optionally include IP addresses in command output.
+
+### Fixed
+- Complete shell input with uppercase letters (e.g., `Cap` to `CapitalizedName` will now work)
 
 ## [1.4.0] - 2022-06-15
 ### Added

internal/completion/helpers.go

@@ -9,12 +9,10 @@ import (
 func MatchStringPrefix(vals []string, key string, caseSensitive bool) []string {
 	var r []string
 	key = strings.Trim(key, "'\"")
-	if caseSensitive {
-		key = strings.ToLower(key)
-	}
+
 	for _, v := range vals {
 		if (caseSensitive && strings.HasPrefix(v, key)) ||
-			(!caseSensitive && strings.HasPrefix(strings.ToLower(v), key)) ||
+			(!caseSensitive && strings.HasPrefix(strings.ToLower(v), strings.ToLower(key))) ||
 			key == "" {
 			r = append(r, Escape(v))
 		}

internal/completion/helpers_test.go

@@ -30,6 +30,13 @@ func TestMatchStringPrefix(t *testing.T) {
 			caseSensitive: true,
 			expected:      []string{"aba"},
 		},
+		{
+			name:          "capitalized",
+			vals:          []string{"Capitalized", "capitalized"},
+			key:           "Cap",
+			caseSensitive: true,
+			expected:      []string{"Capitalized"},
+		},
 		{
 			name:          "doublequotedkey",
 			vals:          []string{"aba", "bba", "cba"},
@@ -52,12 +59,19 @@ func TestMatchStringPrefix(t *testing.T) {
 			expected:      []string{"aba"},
 		},
 		{
-			name:          "case insensitive",
+			name:          "case insensitive (lowercase key)",
 			vals:          []string{"aba", "aBa", "Aba", "aab"},
 			key:           "ab",
 			caseSensitive: false,
 			expected:      []string{"aba", "aBa", "Aba"},
 		},
+		{
+			name:          "case insensitive (uppercase key)",
+			vals:          []string{"aba", "aBa", "Aba", "aab"},
+			key:           "AB",
+			caseSensitive: false,
+			expected:      []string{"aba", "aBa", "Aba"},
+		},
 		{
 			name:          "escaped output",
 			vals:          []string{"a a ", "a(0)", "aab", "a;<!`'", "bbb"},