Skip to content

Commit 2638ac1

Browse files
fix(dbaas): add methods to ManagedDatabaseServiceManager (#232)
1 parent 3f7f64c commit 2638ac1

2 files changed

Lines changed: 22 additions & 3 deletions

File tree

CHANGELOG.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,9 @@ See updating [Changelog example here](https://keepachangelog.com/en/1.0.0/)
55

66
## [Unreleased]
77

8+
### Changed
9+
- GetManagedDatabaseIndices method to return a slice of structs instead of pointers
10+
811
## [6.2.0]
912

1013
### Added

upcloud/service/managed_database.go

Lines changed: 19 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,13 +19,18 @@ type ManagedDatabaseServiceManager interface {
1919
CreateManagedDatabase(ctx context.Context, r *request.CreateManagedDatabaseRequest) (*upcloud.ManagedDatabase, error)
2020
GetManagedDatabase(ctx context.Context, r *request.GetManagedDatabaseRequest) (*upcloud.ManagedDatabase, error)
2121
GetManagedDatabases(ctx context.Context, r *request.GetManagedDatabasesRequest) ([]upcloud.ManagedDatabase, error)
22+
GetManagedDatabaseAccessControl(ctx context.Context, r *request.GetManagedDatabaseAccessControlRequest) (*upcloud.ManagedDatabaseAccessControl, error)
2223
GetManagedDatabaseConnections(ctx context.Context, r *request.GetManagedDatabaseConnectionsRequest) ([]upcloud.ManagedDatabaseConnection, error)
24+
GetManagedDatabaseIndex(ctx context.Context, r *request.GetManagedDatabaseIndexRequest) (*upcloud.ManagedDatabaseIndex, error)
25+
GetManagedDatabaseIndices(ctx context.Context, r *request.GetManagedDatabaseIndicesRequest) ([]upcloud.ManagedDatabaseIndex, error)
2326
GetManagedDatabaseMetrics(ctx context.Context, r *request.GetManagedDatabaseMetricsRequest) (*upcloud.ManagedDatabaseMetrics, error)
2427
GetManagedDatabaseLogs(ctx context.Context, r *request.GetManagedDatabaseLogsRequest) (*upcloud.ManagedDatabaseLogs, error)
2528
GetManagedDatabaseQueryStatisticsMySQL(ctx context.Context, r *request.GetManagedDatabaseQueryStatisticsRequest) ([]upcloud.ManagedDatabaseQueryStatisticsMySQL, error)
2629
GetManagedDatabaseQueryStatisticsPostgreSQL(ctx context.Context, r *request.GetManagedDatabaseQueryStatisticsRequest) ([]upcloud.ManagedDatabaseQueryStatisticsPostgreSQL, error)
2730
DeleteManagedDatabase(ctx context.Context, r *request.DeleteManagedDatabaseRequest) error
31+
DeleteManagedDatabaseIndex(ctx context.Context, r *request.DeleteManagedDatabaseIndexRequest) error
2832
ModifyManagedDatabase(ctx context.Context, r *request.ModifyManagedDatabaseRequest) (*upcloud.ManagedDatabase, error)
33+
ModifyManagedDatabaseAccessControl(ctx context.Context, r *request.ModifyManagedDatabaseAccessControlRequest) (*upcloud.ManagedDatabaseAccessControl, error)
2934
UpgradeManagedDatabaseVersion(ctx context.Context, r *request.UpgradeManagedDatabaseVersionRequest) (*upcloud.ManagedDatabase, error)
3035
GetManagedDatabaseVersions(ctx context.Context, r *request.GetManagedDatabaseVersionsRequest) ([]string, error)
3136
StartManagedDatabase(ctx context.Context, r *request.StartManagedDatabaseRequest) (*upcloud.ManagedDatabase, error)
@@ -284,8 +289,19 @@ func (s *Service) ModifyManagedDatabaseAccessControl(ctx context.Context, r *req
284289
return &ac, s.modify(ctx, r, &ac)
285290
}
286291

287-
// GetManagedDatabaseIndices returns details of access control for an existing user
288-
func (s *Service) GetManagedDatabaseIndices(ctx context.Context, r *request.GetManagedDatabaseIndicesRequest) ([]*upcloud.ManagedDatabaseIndex, error) {
289-
var indices []*upcloud.ManagedDatabaseIndex
292+
// GetManagedDatabaseIndices returns indices of an existing OpenSearch Managed Database service
293+
func (s *Service) GetManagedDatabaseIndices(ctx context.Context, r *request.GetManagedDatabaseIndicesRequest) ([]upcloud.ManagedDatabaseIndex, error) {
294+
indices := make([]upcloud.ManagedDatabaseIndex, 0)
290295
return indices, s.get(ctx, r.RequestURL(), &indices)
291296
}
297+
298+
// GetManagedDatabaseIndex returns details of an index existing OpenSearch Managed Database service
299+
func (s *Service) GetManagedDatabaseIndex(ctx context.Context, r *request.GetManagedDatabaseIndexRequest) (*upcloud.ManagedDatabaseIndex, error) {
300+
index := upcloud.ManagedDatabaseIndex{}
301+
return &index, s.get(ctx, r.RequestURL(), &index)
302+
}
303+
304+
// DeleteManagedDatabaseIndex returns details of an index existing OpenSearch Managed Database service
305+
func (s *Service) DeleteManagedDatabaseIndex(ctx context.Context, r *request.DeleteManagedDatabaseIndexRequest) error {
306+
return s.delete(ctx, r)
307+
}

0 commit comments

Comments
 (0)