fix: add error handling for json unmarshalling

Trdls · Trdls · commit 2dc046b8bc7b · 2020-09-17T11:18:21.000+03:00
diff --git a/upcloud/service/service.go b/upcloud/service/service.go
@@ -136,7 +136,10 @@ func (s *Service) GetServerDetails(r *request.GetServerDetailsRequest) (*upcloud
 		return nil, err
 	}
 
-	json.Unmarshal(response, &serverDetails)
+	err = json.Unmarshal(response, &serverDetails)
+	if err != nil {
+		return nil, fmt.Errorf("unable to unmarshal JSON: %s, %w", string(response), err)
+	}
 
 	return &serverDetails, nil
 }

Original file line number	Diff line number	Diff line change
`@@ -136,7 +136,10 @@ func (s Service) GetServerDetails(r request.GetServerDetailsRequest) (*upcloud`
`136`	`136`	`return nil, err`
`137`	`137`	`}`
`138`	`138`
`139`		`- json.Unmarshal(response, &serverDetails)`
	`139`	`+ err = json.Unmarshal(response, &serverDetails)`
	`140`	`+ if err != nil {`
	`141`	`+ return nil, fmt.Errorf("unable to unmarshal JSON: %s, %w", string(response), err)`
	`142`	`+ }`
`140`	`143`
`141`	`144`	`return &serverDetails, nil`
`142`	`145`	`}`